feat: Add initial support for YouTube clip links - #9532
Open
radmorecameron wants to merge 7 commits into
Open
Conversation
github-actions
Bot
added
the
PR: waiting for review
FreeTubeBot
enabled auto-merge (squash)
July 29, 2026 23:41
radmorecameron
commented
Jul 29, 2026
radmorecameron
marked this pull request as draft
July 29, 2026 23:43
auto-merge was automatically disabled
July 29, 2026 23:43
Pull request was converted to draft
github-actions
Bot
removed
the
PR: waiting for review
radmorecameron
force-pushed
the
add-initial-support-for-clip-links
branch
from
August 2, 2026 20:03
613257f to
1644ed0
Compare
2 tasks
radmorecameron
marked this pull request as ready for review
August 2, 2026 20:35
github-actions
Bot
added
the
PR: waiting for review
FreeTubeBot
enabled auto-merge (squash)
August 2, 2026 20:35
radmorecameron
marked this pull request as draft
August 2, 2026 22:43
auto-merge was automatically disabled
August 2, 2026 22:43
Pull request was converted to draft
github-actions
Bot
removed
the
PR: waiting for review
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
radmorecameron
force-pushed
the
add-initial-support-for-clip-links
branch
from
August 24, 2026 22:00
2dba6f2 to
9d63ca8
Compare
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Member
|
Can be undrafted :) |
radmorecameron
force-pushed
the
add-initial-support-for-clip-links
branch
from
August 26, 2026 22:49
9d63ca8 to
9f06cb5
Compare
radmorecameron
marked this pull request as ready for review
August 26, 2026 22:51
github-actions
Bot
added
the
PR: waiting for review
FreeTubeBot
enabled auto-merge (squash)
August 26, 2026 22:52
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Aug 28, 2026
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
radmorecameron
added
PR: waiting for review
Contributor
|
Navigating to the URL with Invidious API throws too |
radmorecameron
commented
Aug 30, 2026
Co-authored-by: Cameron Radmore <radmorecameron@gmail.com>
Member
Author
|
Both the Invidious and local api should be working now. Issue was a mix of typo + updating the name of a param in my YouTube.js PR and forgetting to reflect that change here. |
absidue
reviewed
Sep 1, 2026
Comment on lines
+2498
to
+2506
| const parsedParams = ClipParams.decode(Utils.base64ToU8(decodeURIComponent(clipResponse.payload.params))) | ||
|
|
||
| return { | ||
| videoId, | ||
| startTime: parsedParams.clipParamData.startTime / 1000, // convert to seconds | ||
| endTime: parsedParams.clipParamData.endTime / 1000, // convert to seconds | ||
| clipTitle: parsedParams.clipParamData.clipTitle, | ||
| clipMetadata: parsedParams.clipParamData.clipMetadata | ||
| } |
Member
There was a problem hiding this comment.
As this section of the code is the same for the local and Invidious APIs apart from where the video ID and params string is read from, could you please extract it into a shared function that takes the video ID and params text as the input, decodes it and returns the object.
Member
Author
There was a problem hiding this comment.
I created a new shared.js file in the api folder. I felt like the current utils.js wasn't a great fit for this shared code since it wouldn't have much use outside of the local.js and invidious.js files.
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
radmorecameron
added
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
#4323
Description
This PR adds initial support for clip links.
Testing
Desktop