Repository navigation
feat: mobile app: add yield history filtering by asset type and date range (#692) - #877
Merged
ONEONUORA merged 1 commit intoAug 30, 2026
Conversation
|
@Divine-designs Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
ONEONUORA
approved these changes
Aug 30, 2026
ONEONUORA
left a comment
Contributor
There was a problem hiding this comment.
Great job @Divine-designs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #692
Summary
Adds yield transaction history filtering by asset type and date range to the history screen (the screen that actually lists yield transactions;
yield-transaction.tsxis an orphaned deposit/withdraw form in this codebase).Filter plumbing
TransactionFiltersgains anasset?: stringfield (src/types/transaction.ts).fetchTransactionsapplies the asset predicate client-side AND builds the corresponding backend query params (type,asset,date_from,date_to, …) ready for the live API.api.getYieldTransactions({ asset, dateFrom, dateTo })— the endpoint referenced in the issue — returns the filtered yield transaction list.UI (
(personal)/history.tsx)TransactionFilterSheetalso gains an Asset chip row and date from/to inputs for custom ranges.Acceptance Criteria
getYieldTransactions)Tests
__tests__/yieldHistory.test.ts(4 cases): asset-only yield filter, date-range filter,getYieldTransactionsparam passing, and yield-only excludes non-yield txs.Touched files pass tsc (no new errors), eslint, and prettier.