Repository navigation
fix(dashboard): RBAC UI hiding and export buttons (#1034, #1035) - #1119
Merged
ONEONUORA merged 1 commit intoOct 17, 2026
Merged
Conversation
…acverse#1035) - Fracverse#1034: Apply isSuperAdmin() gate to Export Users button, wallet Connect Freighter button, and !isSuperAdmin warning panel in dashboard/page.tsx using the existing useSuperAdmin() hook from auth-context.tsx - Fracverse#1034: Fix syntax errors in dashboard/page.tsx — removed corrupted duplicate Payout Statistics, Vault Trend Charts, and Wallet sections that contained empty JSX expressions (value={}, tickFormatter, className template literals) and orphaned brackets - Fracverse#1034: Fix useEffect cleanup — moved cancelled=true return to effect scope and added .finally() to set chartsLoading(false) after API call - Fracverse#1035: Export CSV/JSON buttons already implemented in transactions/page.tsx via ExportButtons component and exportAuditRows() helper using URL.createObjectURL(blob) Closes Fracverse#1034 Closes Fracverse#1035
|
@Gracie418502 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
ONEONUORA
approved these changes
Oct 17, 2026
ONEONUORA
left a comment
ONEONUORA
left a comment
Contributor
There was a problem hiding this comment.
Great job @Gracie418502
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves two dashboard issues in a single PR.
#1034 — RBAC UI hiding for read-only users
useSuperAdmin()hook fromlib/auth-context.tsxat the top ofdashboard/app/dashboard/page.tsxdisabled={!isSuperAdmin}so non-superadmins cannot trigger the Privy identity CSV exportdisabled={!isSuperAdmin}so only superadmins can authorise on-chain vault operations🔒 Superadmin access requiredwarning panel inside the Wallet Authorization card when!isSuperAdminvalue={}, emptytickFormatter/formatterarrow functions, emptyclassNametemplate literal) and orphaned bracketsuseEffectcleanup — moved thereturn () => { cancelled = true; }to the correct scope (effect body, not inside.catch()) and added.finally()to clearchartsLoading#1035 — Export CSV/JSON buttons for transaction audit tables
Already implemented in
dashboard/app/dashboard/transactions/page.tsx:exportAuditRows()helper converts rows to a Blob and triggers a browser download usingURL.createObjectURL(blob)ExportButtonscomponent renders Export CSV and Export JSON buttons, disabled when table is emptyFiles Changed
dashboard/app/dashboard/page.tsx— RBAC gates + syntax fixTesting
isSuperAdmincheck appears on all three gated elements (lines 312, 657, 684)ExportButtonsused on both tables in transactions pageCloses #1034
Closes #1035