Repository navigation
fix(dashboard): show XDR decode errors instead of crashing the inspector - #1117
Merged
ONEONUORA merged 1 commit intoOct 16, 2026
Merged
Conversation
decodeXdr throws on unknown payloads, but it ran inside XdrViewer's render, so the try/catch around <XdrViewer /> in PaymentDetailDialog never caught it and invalid XDR crashed the dialog. Decode inside XdrViewer and render the error panel there. Adds tests for envelope, ScVal, invalid input and close.
|
@Yunusabdul38 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
ONEONUORA
approved these changes
Oct 16, 2026
ONEONUORA
left a comment
ONEONUORA
left a comment
Contributor
There was a problem hiding this comment.
Great job @Yunusabdul38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid XDR threw during
XdrViewerrender, which the existing try/catch around<XdrViewer />can't catch, so the dialog crashed instead of showing "Failed to decode XDR". Decode errors are now handled inside the viewer. Adds tests for the inspector (envelope summary, ScVal, invalid input, close). 2 files, +100/-16.Closes #1029
Closes #1031
closes #1028
Closes #1027