Repository navigation
Rename propose_admin to propose_new_admin (issue #989) - #1095
Closed
KingDavid9999 wants to merge 1 commit into
Closed
KingDavid9999 wants to merge 1 commit into
KingDavid9999 wants to merge 1 commit into
Conversation
Aligns the 2-step admin transfer function name and doc/comment references with issue Fracverse#989 (previously referenced internally as event emission are unchanged. - contracts/contracts/user_registry/src/lib.rs: rename propose_admin -> propose_new_admin, update issue references (Fracverse#776 -> Fracverse#989) in doc comments, fix Events trait import and Symbol::to_val() usage needed to compile the test module - contracts/contracts/user_registry/src/test.rs: update call sites to propose_new_admin, update issue reference (Fracverse#776 -> Fracverse#989), fix missing Events trait import Closes Fracverse#989
|
@KingDavid9999 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the 2-step admin transfer function name and doc/comment
references with issue #989 (previously referenced internally as
event emission are unchanged.
-> propose_new_admin, update issue references (smart contract: Write tests for user registry admin 2-step ownership transfer #776 -> contract: CONTRACT: IMPLEMENT USER REGISTRY ADMIN TRANSFER 2-STEP VERIFICATION PROTOCOL #989) in
doc comments, fix Events trait import and Symbol::to_val() usage
needed to compile the test module
propose_new_admin, update issue reference (smart contract: Write tests for user registry admin 2-step ownership transfer #776 -> contract: CONTRACT: IMPLEMENT USER REGISTRY ADMIN TRANSFER 2-STEP VERIFICATION PROTOCOL #989), fix
missing Events trait import
Closes contract: CONTRACT: IMPLEMENT USER REGISTRY ADMIN TRANSFER 2-STEP VERIFICATION PROTOCOL #989