Skip to content

[10][FIX] Variability factor increase red zone #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hparfr wants to merge 81 commits into
base: 10.0
Choose a base branch
from
Open

[10][FIX] Variability factor increase red zone #57

Changes from 1 commit
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
11bc3d3
add demo data
JordiBForgeFlow Sep 28, 2017
adc0f56
various improvements
JordiBForgeFlow Oct 2, 2017
138d9ff
fix
JordiBForgeFlow Oct 3, 2017
457b92d
fix
JordiBForgeFlow Oct 3, 2017
b5d3ca2
add mrp_mts_mto demo data
JordiBForgeFlow Oct 3, 2017
8c57f50
[9.0][FIX] ddmrp_history: ondelete cascade
LoisRForgeFlow Oct 9, 2017
1a905bc
[9.0][IMP] ddmrp: split ADU computations into a new cron job.
LoisRForgeFlow Sep 15, 2017
fd2c1cf
[FIX] ddmrp_history: wrong depiction
LoisRForgeFlow Nov 7, 2017
eb8fa91
[FIX] ddmrp: wrong string
LoisRForgeFlow Nov 7, 2017
976db42
[9.0][IMP] ddmrp: enhance performace
LoisRForgeFlow Nov 21, 2017
a33d885
[9.0][FIX] ddmrp: fix infinite recursion
LoisRForgeFlow Dec 1, 2017
dc2f421
[9.0] ddmrp: addd ddmrp specific config menu
LoisRForgeFlow Dec 14, 2017
a3d3e31
[9.0][IMP] ddmrp_mrp_production_request: enhance performace
LoisRForgeFlow Nov 21, 2017
6d1433c
[9.0][IMP] ddmrp: add execution status to PO lines.
LoisRForgeFlow Dec 15, 2017
f759d81
PO reference clickable
LoisRForgeFlow Dec 18, 2017
8d6bc32
[9.0][FIX] ddmrp_mrp_production_request: fix infinite recursion
LoisRForgeFlow Dec 15, 2017
14e1e48
[9.0][IMP] ddmrp: enhance PO lines view
LoisRForgeFlow Dec 20, 2017
8439601
[9.0][FIX] ddmrp: consider past due moves.
LoisRForgeFlow Dec 28, 2017
6c3a8fb
[9.0][FIX] ddmrp: ignore reservations
LoisRForgeFlow Nov 9, 2017
3eccfe6
[9.0][REM] stock_orderpoint_uom: moved to OCA/stock-logistics-warehouse
LoisRForgeFlow Dec 27, 2017
4d3a2d2
[9.0][REM] stock_demand_estimate: moved to OCA/stock-logistics-warehouse
LoisRForgeFlow Dec 27, 2017
b421a3e
[9.0][REM] stock_warehouse_orderpoint_stock_info and stock_warehouse_…
LoisRForgeFlow Dec 27, 2017
f33a83c
[ADD] travis CI
LoisRForgeFlow Dec 27, 2017
1126ef8
[9.0][REM] mrp_production_service
LoisRForgeFlow Jan 8, 2018
832992c
[10.0][MIG] ddmrp
LoisRForgeFlow Dec 28, 2017
1718672
[REM] .idea files
LoisRForgeFlow Jan 22, 2018
499e4d6
[UPD] .gitignore
LoisRForgeFlow Jan 22, 2018
54f4b72
[10.0][MIG] ddmrp_exclude_moves_adu_cal
LoisRForgeFlow Jan 22, 2018
616c5c4
[9.0][FIX] Use date_range intsead of period.id (#30)
hparfr Feb 14, 2018
50b00aa
[9.0][FIX] ddmrp: Add wizard in init file (#31)
florian-dacosta Feb 19, 2018
5d1c0c3
[9.0][IMP] make DLT computed
LoisRForgeFlow Sep 12, 2017
f19481f
add location to demo data
JordiBForgeFlow Sep 29, 2017
e759332
improve bom structure report
JordiBForgeFlow Sep 29, 2017
0d413cc
move dlt logic to bom
JordiBForgeFlow Sep 29, 2017
9a7fc92
dlt: several improvements
JordiBForgeFlow Oct 3, 2017
c1a76f6
[9.0][FIX] readme and bom syntax regarding dlt computation
LoisRForgeFlow Feb 20, 2018
3f3510d
Merge pull request #13 from Eficent/9.0-imp-ddmrp-dlt
LoisRForgeFlow Feb 20, 2018
0b9a21f
[9.0][ADD] ddmrp_adjustment
LoisRForgeFlow Sep 18, 2017
1f63dda
[9.0][IMP] ddmrp_adjustment: consider lead time on demand alocation f…
LoisRForgeFlow Feb 20, 2018
a9812bf
[9.0][IMP] ddmrp_adjustment: implement Lead Time Adj Factor
LoisRForgeFlow Feb 21, 2018
d52927f
[9.0][ADD] ddmrp_adjustment
LoisRForgeFlow Sep 18, 2017
d260742
[9.0][IMP] ddmrp_adjustment: consider lead time on demand alocation f…
LoisRForgeFlow Feb 20, 2018
ae5c1be
[9.0][IMP] ddmrp_adjustment: implement Lead Time Adj Factor
LoisRForgeFlow Feb 21, 2018
43244c2
add setup file
LoisRForgeFlow Feb 21, 2018
c5e66d5
Merge pull request #15 from Eficent/9.0-add-ddmrp_adjustment
LoisRForgeFlow Feb 21, 2018
9ba52ba
[REM] .idea
LoisRForgeFlow Feb 21, 2018
4dda1b5
[9.0] ddmrp: add setup files
LoisRForgeFlow Feb 21, 2018
3126db8
[UPD] .gitignore
LoisRForgeFlow Feb 21, 2018
cd8cb09
[9.0][ADD] ddmrp_product_replace
LoisRForgeFlow Dec 14, 2017
2698b8b
[9.0][FIX] demand estimate domains (#34)
florian-dacosta Feb 21, 2018
5c0b81a
[MIG] ddmrp_adjustment: Migration to 10.0
HviorForgeFlow Feb 21, 2018
3d9c473
setup.py
HviorForgeFlow Feb 21, 2018
aab7d68
fixes
rgarnau Feb 22, 2018
fd29796
Merge pull request #37 from Eficent/10.0-fix-setup
Feb 22, 2018
1d5e41f
[fix] setup
rgarnau Feb 22, 2018
54c2251
[9.0][ADD] setup files
LoisRForgeFlow Feb 22, 2018
8049241
[10.0][MIG] ddmrp
LoisRForgeFlow Dec 28, 2017
7969002
[UPD] .gitignore
LoisRForgeFlow Jan 22, 2018
7c55cf5
[10.0][MIG] ddmrp_exclude_moves_adu_cal
LoisRForgeFlow Jan 22, 2018
1f8d0cf
[MIG] ddmrp_adjustment: Migration to 10.0
HviorForgeFlow Feb 21, 2018
fe6d8e9
setup.py
HviorForgeFlow Feb 21, 2018
bf1104e
fixes
rgarnau Feb 22, 2018
394b673
[fix] setup
rgarnau Feb 22, 2018
c55c8e6
[10.0][FIX] ddmrp fixes
LoisRForgeFlow Jan 24, 2018
14826e4
Merge branch '10.0' into 10.0-mig-ddmrp
LoisRForgeFlow Mar 6, 2018
fb24d3a
[10.0][MIG] ddmrp: bom structure report
LoisRForgeFlow Mar 6, 2018
2a5e0c3
fix travis
LoisRForgeFlow Mar 6, 2018
1e56a9b
Merge pull request #25 from Eficent/10.0-mig-ddmrp
LoisRForgeFlow Mar 6, 2018
1383609
[10.0][MIG] ddmrp_product_replace
LoisRForgeFlow Jan 24, 2018
535f6b6
[10.0][MIG] ddmrp_history
LoisRForgeFlow Jan 22, 2018
9694fa8
[10.0][MIG] ddmrp_mrp_production_request
LoisRForgeFlow Jan 22, 2018
e9ced2f
[FIX] setup and travis
LoisRForgeFlow Mar 6, 2018
fdf2de4
[10.0][MIG] ddmrp_adjustment: migrate latest changes
LoisRForgeFlow Mar 6, 2018
5645fe9
[10.0][FIX] ddmrp: enable the use of override buffers
LoisRForgeFlow Mar 8, 2018
94cc358
change supply qualification for net flow position to consider only su…
JordiBForgeFlow Mar 6, 2018
4c6511d
[9.0][FIX] ddmrp: issue with date on manually created pickings.
LoisRForgeFlow Mar 8, 2018
e58b170
[10.0][ADD] Execution history buffer (#49)
Mar 9, 2018
a88a005
adding ddmrp buffer profiles data
HviorForgeFlow Mar 6, 2018
185bd9f
[10.0][FIX] ddmrp: dlt computeation considers distributed parts.
LoisRForgeFlow Mar 9, 2018
e640b45
Variability factor should increase red zone instead of reducing it
hparfr Mar 14, 2018
d1b7c6f
adapt '1+' for only minmax
hparfr Mar 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ddmrp/models/stock_warehouse_orderpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,16 @@ class StockWarehouseOrderpoint(models.Model):
"product_uom.rounding", "red_override")
def _compute_red_zone(self):
for rec in self:

@rousseldenis rousseldenis Mar 29, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hparfr @lreficent Maybe a _get_lead_time_factor() method should be a good approach ?

@hparfr hparfr Mar 29, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it will make sense now. It can be refactored later when some new buffers will be added. (like time buffer 👯‍♂️ )

@rousseldenis rousseldenis Mar 29, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that's what I've in mind 😃

It was to 'decouple' a little bit code!

if rec.replenish_method in ['replenish', 'min_max']:

@LoisRForgeFlow LoisRForgeFlow Mar 15, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to split this, for replenish the code is good. For min_max as we discussed yesterday they changed the computation of red zone on the 2nd edition. Now it is RZ(min_max) = adu * dlt * (1 + variability factor)

@LoisRForgeFlow LoisRForgeFlow Mar 15, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to split this, for replenish the code is good

Here I meant the current code without the changes on this PR

factor = rec.buffer_profile_id.lead_time_id.factor
if rec.replenish_method == 'min_max':
factor = factor + 1
rec.red_base_qty = float_round(
rec.dlt * rec.adu *
(1 + rec.buffer_profile_id.lead_time_id.factor),
rec.dlt * rec.adu * factor,
precision_rounding=rec.product_uom.rounding)
rec.red_safety_qty = float_round(
rec.red_base_qty *
(1 + rec.buffer_profile_id.variability_id.factor),
rec.red_base_qty * factor,
precision_rounding=rec.product_uom.rounding)
rec.red_zone_qty = rec.red_base_qty + rec.red_safety_qty
else:
Expand Down