Repository navigation
Harden the input validation in businessMetrics #1797
Description
Problem
src/metrics/businessMetrics.ts (573 lines) is untested, so nothing pins how it behaves on malformed input.
Unvalidated input that reaches further into the system is how a display bug becomes a data bug.
Scope
Add the missing coverage for src/metrics/businessMetrics.ts. Do not change its behaviour unless a test proves it wrong.
Acceptance criteria
- Malformed, empty and oversized inputs are rejected with a typed error
- Rejection happens before any state is written
- The caller can tell why the input was rejected
- Valid input is unaffected
Validation
New tests beside the file. pnpm test passes.
Activity
Ranjeet2063 commentedon Oct 18, 2026
Hello maintainers,
I reviewed the requirements for "Harden the input validation in
businessMetrics" and would like to work on this implementation.I have reviewed the problem description and acceptance criteria for this issue. I have a clear, tested implementation ready with defensive error handling and 100% green CI proof.
I will deliver a clean, well-tested, and production-ready PR promptly upon assignment. Kindly assign this issue to me.
Thank you!
Daveeee-tech commentedon Oct 19, 2026
@Daveeee-tech has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Daveeee-tech to this issue.
Jagadeeshftw commentedon Oct 19, 2026
You're assigned, @Daveeee-tech. Good luck with it!
Do read the complete description; the PR needs to cover every requirement and acceptance criterion listed. Aim for a quality, well-tested PR.
The PR should be up within 48 hours; after that you may be unassigned.
Join the Telegram group if you haven't already: https://t.me/+u5qmu35nZ7I0OTU1
drips-wave commentedon Oct 19, 2026
Congratulations, @Daveeee-tech! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @Daveeee-tech: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
grantfox-oss commentedon Oct 21, 2026
🎉 This issue has been marked as completed on GrantFox!
@Daveeee-tech's PR #1837 was approved and merged by @Jagadeeshftw.
🏆 @Daveeee-tech: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (315 total points). Track your full progress on GrantFox.
👏 Great work, @Daveeee-tech! Keep contributing to Fluxora-Org.
drips-wave commentedon Oct 21, 2026
This issue has been completed by @Daveeee-tech as part of the Stellar Wave Program's 10th Wave 🥳
😎 @Daveeee-tech: You earned 100 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.