Repository navigation
Extract leftover hardcoded UI strings into lib/copy modules - #1013
Merged
Austinaminu2 merged 1 commit intoOct 17, 2026
Merged
Conversation
Moves leftover user-visible strings out of the create form, stream detail page, ClearLocalData and NotificationBell into their lib/copy modules so all UI copy lives in one place. Closes FlowwStar#960 Closes FlowwStar#961 Closes FlowwStar#962 Closes FlowwStar#963
|
@Userhorlie Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the lib/copy extraction work by moving the remaining hardcoded user-visible strings out of four components into their copy modules. Wording is unchanged; only string location moves.
ClearLocalData: added a top-levelsettingsCopy.clearLocalDatakey (title, description, confirm prompt, Confirm/Cancel/Clear buttons, plus a dynamictoast.cleared(count)helper and theReloading…description) and wired the component to it.NotificationBell: createdlib/copy/notifications.tsexportingnotificationsCopy(dismiss aria-label, dynamic unread-count trigger aria-label as a function,9+badge overflow, panel aria-label, heading, Clear all, empty state) following the dashboard/streams copy pattern.createFormCopy— draft-save warning toast title/description, recipient removed/renamed toasts, 'Fetching price…' (now reuses the existing copy key), 'Price unavailable for X', Rename/Remove entry aria-labels (as functions), cliff amount placeholder, and the rename-recipient dialog strings (newrenameDialogkey).cleanupDialogtostreamDetailCopy('Remove from history' title/description, Cancel, 'Removing…', 'Remove permanently'), wired the share dropdown to the existingshareButtonskeys, and extracted the ProgressBar aria-label, the header 'Remove from history' button, and the FeeEstimateDialogactionvalues.Testing
npm run typecheckpasses (one pre-existing error incomponents/streams/dashboard-stats.stories.tsxon main remains, unrelated).npm run lintreports 0 errors.Closes #960
Closes #961
Closes #962
Closes #963