Repository navigation
Extract hardcoded UI strings in AddressBookSettings and StreamPreview into lib/copy - #1011
Merged
Austinaminu2 merged 2 commits intoOct 17, 2026
Merged
Conversation
Moves every user-visible string out of AddressBookSettings and StreamPreview into lib/copy/settings.ts and lib/copy/create-form.ts respectively, following the established copy-module pattern. Closes FlowwStar#957 Closes FlowwStar#958
|
@RennyThompson Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the remaining hardcoded UI strings from two components into the existing
lib/copymodules, following the pattern already established for the settings page/webhook settings and the create-stream form. Wording is unchanged; interpolated strings are expressed as arrow functions.#958 — AddressBookSettings
All user-visible strings from
components/settings/address-book-settings.tsxnow live under a new top-levelsettingsCopy.addressBookinlib/copy/settings.ts:emptyState— empty-state textsaveAria,cancelAria,editAria,deleteAria— buttonaria-labelsconfirmRemoveLabel,confirmButton,cancelButton— inline delete-confirmation UIvalidation.emptyLabel— "Label cannot be empty" toasttoasts.entryUpdated,toasts.entryRemoved— success toastsThe existing
settingsCopy.page.sections.addressBook(settings page section heading) is untouched.#957 — StreamPreview
All user-visible strings from
components/streams/stream-preview.tsxnow live under a newcreateFormCopy.streamPreviewkey inlib/copy/create-form.ts:emptyState,titlelowRateWarning(perHour, symbol)— interpolated low-rate warningtotalDurationLabel,unlockRateLabel,cliffAmountLabel,cliffWaitLabel,timelineLabel,startLabelperMonthSuffix,perHourSuffix,perDaySuffix— rate unit suffixescliffLabel(duration),endLabel(duration)— interpolated timeline labelsduration.days/hours/minutes(n),duration.none,duration.belowOneMinute—formatDurationoutputNon-visible strings (
className,data-testid, event keys, imported helper values) are intentionally left in place.Closes #957
Closes #958