Repository navigation
Extract hardcoded UI strings in Navbar into lib/copy/navigation.ts - #1010
Merged
Austinaminu2 merged 1 commit intoOct 17, 2026
Merged
Conversation
Moves every user-visible string out of the Navbar into a new lib/copy/navigation.ts module, following the established copy-module pattern. Closes FlowwStar#953
3 tasks
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts every user-visible string out of
components/layout/navbar.tsxand into a newlib/copy/navigation.tsmodule exportingnavigationCopy.This follows the established copy-module pattern used by
lib/copy/dashboard.tsandlib/copy/streams.ts: a plain object export with a leading comment describing the component it serves, keeping the Navbar's strings in one place as a step toward i18n-readiness.What moved
Dashboard,Streams,Analytics,Settings)aria-labelMainnet/Testnet)sr-onlylabel and items (Toggle theme,Light,Dark,System)before/switchTo/afterfragments so the existing<strong>markup and rendered wording are preserved)Notes
data-testid, href/src paths, object keys, enum values, comments) were intentionally left in place.navigationCopyreferences.npm run typecheckreports no errors in the changed files. (One pre-existing, unrelated error remains incomponents/streams/dashboard-stats.stories.tsx.)Closes #953