Skip to content

dx: useNotifications.ts is dead scaffold code — unused duplicate of use-notifications.ts #281

Closed

Description

@Austinaminu2

Problem

`hooks/useNotifications.ts` (PascalCase) is a second, differently-cased hook exporting the same name `useNotifications`, whose `poll()` body is entirely commented out as a placeholder, and which lacks a `'use client'` directive. Repo-wide grep shows zero importers — only `hooks/use-notifications.ts` (kebab-case) is actually used, by `components/layout/notification-bell.tsx`.

Location

`hooks/useNotifications.ts` (entire file, unused)

Impact

Dead scaffold code that risks confusing future contributors into editing or importing the wrong file (two files with the same exported name is an easy mistake to make).

Suggested fix

Delete `hooks/useNotifications.ts` since it has no importers and its functionality is superseded by `use-notifications.ts`.

Activity

  1. maixuancanh commented on Jul 25, 2026

    @maixuancanh

    @maixuancanh has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

    Hi, I'd like to take this cleanup. I'll first verify there are no imports of hooks/useNotifications.ts, including case-sensitive paths, then remove the unused duplicate and confirm use-notifications.ts remains the only active implementation. I'll run the project's lint, typecheck, and relevant tests and keep the patch limited to this dead file and any directly affected references.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @maixuancanh to this issue.

  2. Xoulomon commented on Jul 26, 2026

    @Xoulomon
    Contributor

    @Xoulomon has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

    Hey Maintainer, I have gone through the details of the issue and i am capable of resolving it, I would love to be assigned to work on it ASAP. Thanks in advance

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Xoulomon to this issue.

  3. drips-wave commented on Jul 26, 2026

    @drips-wave

    Congratulations, @Xoulomon! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on July 30, 2026.

    🧑‍💻 @Xoulomon: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  4. grantfox-oss commented on Jul 26, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign | FWC26 campaign!

    @Xoulomon's PR #414 was approved and merged by @Austinaminu2.

    🏆 @Xoulomon: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (382 total points). Track your full progress on GrantFox.

    👏 Great work, @Xoulomon! Keep contributing to FlowwStar.

  5. added a commit that references this issue on Jul 26, 2026
  6. drips-wave commented on Jul 26, 2026

    @drips-wave

    This issue has been completed by @Xoulomon as part of the Stellar Wave Program's 7th Wave 🥳

    😎 @Xoulomon: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programfrontendNext.js frontend

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions