Skip to content

testing: accessibility.spec.ts has no automated a11y scan or focus/keyboard-nav tests #238

Closed

Description

@Austinaminu2

Problem

e2e/accessibility.spec.ts is 23 lines with 3 tests, and only checks that a skip-link exists and that an h1 is visible on the page. There is no automated accessibility scanner (e.g. @axe-core/playwright), no keyboard-navigation test, and no focus-trap test for any of the app's modal dialogs (components/ui/dialog.tsx, tx-preview-dialog.tsx, fee-estimate-dialog.tsx).

Impact

The accessibility test suite gives a false sense of coverage — "we have an accessibility spec file" — while catching almost nothing an actual a11y regression would trigger: missing aria-labels, insufficient color contrast, keyboard traps in dialogs, or unreachable interactive elements. For a financial app where users interact with modals for irreversible actions (cancel stream, confirm transaction), this is a real user-facing risk, not just a compliance checkbox.

Suggested fix

Add @axe-core/playwright (or similar) and run it against key pages/flows (dashboard, create-stream, stream-detail with dialogs open). Add explicit keyboard-navigation tests (tab order, Escape closes dialogs, focus returns to the trigger element) for at least the cancel-stream and transaction-preview dialogs.

Location

  • e2e/accessibility.spec.ts
  • components/ui/dialog.tsx, tx-preview-dialog.tsx, fee-estimate-dialog.tsx

Activity

  1. OpadijoIdris commented on Jul 17, 2026

    @OpadijoIdris
    Contributor

    I would love to work on this task. Kindly assign

  2. summer-0ma commented on Jul 17, 2026

    @summer-0ma

    Hi Maintainer !!!!
    I will like to work on this issue.Please do assign it to me so i can fix it, Thank you.!!!

  3. summer-0ma commented on Jul 17, 2026

    @summer-0ma

    Hi Maintainer !!!!
    I will like to work on this issue.Please do assign it to me so i can fix it, Thank you.!!!

  4. darcszn commented on Jul 20, 2026

    @darcszn
    Contributor

    Hello Maintainer, i'm an experienced full stack dev and i will like to work on this issue.
    if you'll kindly assign, the issue will be resolved.
    ETA: 5 Hours

  5. grantfox-oss commented on Jul 20, 2026

    @grantfox-oss

    🦊 GrantFox — @darcszn has been assigned to this issue as part of the Official Campaign | FWC26 campaign!

    Next steps:

    1. Open a Pull Request referencing this issue (e.g., Closes #238)
    2. Your PR will be reviewed by the FlowwStar maintainers

    Good luck! Track your progress on GrantFox.

  6. grantfox-oss commented on Jul 22, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign | FWC26 campaign!

    @darcszn's PR #261 was approved and merged by @Austinaminu2.

    🏆 @darcszn: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,129 total points). Track your full progress on GrantFox.

    👏 Great work, @darcszn! Keep contributing to FlowwStar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Campaign: Official Campaign | FWC26frontendNext.js frontendtestingTests and QA

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions