Skip to content

bug: CSV cliff_duration column is parsed but silently discarded, cliff never applied #234

Closed

Description

@Austinaminu2

Problem

lib/csv-parser.ts supports a cliff_duration header alias (line 29) and stores it on parsed rows (lines 157-159). However, the only consumer, app/app/create/batch/page.tsx:110-142, never reads source.cliff_duration — it only reads source.cliff_time.

Impact

A CSV that uses the cliff_duration column (a relative duration, presumably meant as an alternative to specifying an absolute cliff_time) silently produces a stream with no cliff at all — the value is parsed successfully but then dropped on the floor with zero validation error or warning shown to the person uploading the CSV. For a batch of payroll/vesting streams, this means cliffs that were supposed to apply simply don't, with no feedback that anything went wrong.

Suggested fix

Either implement the conversion from cliff_duration to an absolute cliff_time (relative to each row's start_time) in batch/page.tsx, or remove the cliff_duration alias from the parser entirely if it isn't meant to be supported, so the CSV template/docs don't advertise a column that does nothing.

Location

  • lib/csv-parser.ts:29,157-159
  • app/app/create/batch/page.tsx:110-142

Activity

  1. SYMBAxx commented on Jul 20, 2026

    @SYMBAxx
    Contributor

    please assign me this

  2. grantfox-oss commented on Jul 20, 2026

    @grantfox-oss

    🦊 GrantFox — @SYMBAxx has been assigned to this issue as part of the Official Campaign | FWC26 campaign!

    Next steps:

    1. Open a Pull Request referencing this issue (e.g., Closes #234)
    2. Your PR will be reviewed by the FlowwStar maintainers

    Good luck! Track your progress on GrantFox.

  3. grantfox-oss commented on Jul 21, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign | FWC26 campaign!

    @SYMBAxx's PR #259 was approved and merged by @Austinaminu2.

    🏆 @SYMBAxx: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (274 total points). Track your full progress on GrantFox.

    👏 Great work, @SYMBAxx! Keep contributing to FlowwStar.

  4. added a commit that references this issue on Jul 21, 2026
    ddae8b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Campaign: Official Campaign | FWC26bugSomething isn't workingfrontendNext.js frontend

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions