Skip to content

Remove PHPStan ignore lines #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Firehed merged 2 commits into from
Aug 11, 2026
Merged

Remove PHPStan ignore lines #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c47787
All GMP ignores are fixed upstream
Firehed Aug 11, 2026
b43e6d4
PHP Matrix too
Firehed Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- '8.3'
- '8.4'
- '8.5'
- '8.6-dev'
- '8.6'

steps:
- name: Check out code
Expand Down
11 changes: 4 additions & 7 deletions src/PublicKey/EllipticCurve.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,16 +152,13 @@ private function isOnCurve(): bool

// This is only tested with P256 (secp256r1) but SHOULD be the same for
// the other curves (none of which are supported yet)/
$x3 = $x ** 3; // @phpstan-ignore pow.leftNonNumeric (phpstan/phpstan#14288)
$ax = $a * $x; // @phpstan-ignore mul.leftNonNumeric, mul.rightNonNumeric (phpstan/phpstan#14288)
// phpcs:disable
$x3 = $x ** 3;
$ax = $a * $x;
// (need the long line for PHPStan to parse)
// @phpstan-ignore plus.leftNonNumeric, plus.leftNonNumeric, plus.rightNonNumeric, plus.rightNonNumeric, mod.leftNonNumeric, mod.rightNonNumeric (phpstan/phpstan#14288)
$rhs = ($x3 + $ax + $b) % $p;
// phpcs:enable

$y2 = $y ** 2; // @phpstan-ignore pow.leftNonNumeric (phpstan/phpstan#14288)
$lhs = $y2 % $p; // @phpstan-ignore mod.leftNonNumeric, mod.rightNonNumeric (phpstan/phpstan#14288)
$y2 = $y ** 2;
$lhs = $y2 % $p;

// Functionaly, `$lhs === $rhs` but avoids reference equality issues
// w/out having to introduce loose comparision ($lhs == $rhs works)
Expand Down
Loading