Skip to content

Use extracted signCount local in encodeV2 - #104

Merged
Firehed merged 2 commits into
mainfrom
remove-dead-signcount-variable
Aug 11, 2026
Merged

Firehed merged 2 commits into
mainfrom
remove-dead-signcount-variable

Conversation

@Firehed

@Firehed Firehed commented Aug 11, 2026

Copy link
Copy Markdown
Owner

Codecs\Credential::encodeV2 extracts $signCount alongside $rawId and $rawCbor, then calls $credential->getSignCount() again in the sprintf instead of using it. No behavior change; the local is now used the way the two adjacent ones are.

🤖 Generated with Claude Code

@codecov

codecov Bot commented Aug 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.48%. Comparing base (9d4d0fe) to head (e1a4b9f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #104   +/-   ##
=========================================
  Coverage     81.48%   81.48%           
  Complexity      343      343           
=========================================
  Files            33       33           
  Lines           994      994           
=========================================
  Hits            810      810           
  Misses          184      184           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Firehed
Firehed enabled auto-merge (squash) August 11, 2026 19:58
@Firehed
Firehed merged commit 96e6cc3 into main Aug 11, 2026
14 checks passed
@Firehed
Firehed deleted the remove-dead-signcount-variable branch August 11, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant