Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## e2e-variable-definitions #684 +/- ##
===========================================================
Coverage 99.67% 99.67%
Complexity 1900 1900
===========================================================
Files 135 135
Lines 4873 4873
===========================================================
Hits 4857 4857
Misses 16 16 ☔ View full report in Codecov by Harness. |
Firehed
added this pull request to stack #688
October 4, 2026 01:49
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #683.
Moves
DefinitionHandlerIntegrationTestonto the end-to-end tier.Scripts
NoAnswer()where it asserted none. The attribute-class case was already covered bydefinition-open-documents.newreuse existing markers;EdgeCases/BuiltinDefinitions.php. Built-ins have no file to go to on any PHP version, so these answers are stable.selfkeyword inself::classoutside a class, and at line 0, column 0. No marker can place those cursors, and neither covered anything unique.Malformed parameters
MessageErrorTestsends four malformed definition requests and checks that each is answered and the session carries on. Today the answer is anullresult; JSON-RPC 2.0 §5.1 also definesInvalidParamsfor this. The handler's own parameter checks are covered byDefinitionHandlerTest.Unit tests
VariableResolutionTest(from #683) is renamedExpressionResolutionTest, since it now covers more than variables. It gains the resolution paths only the original reached: a variable assigned by a ternary, and a static property or constant on a variable class.Coverage: unchanged, file by file.
🤖 Generated with Claude Code