Move tests/Parity into the integration testsuite - #666
Merged
Merged
Conversation
Every parity test builds the full production stack through BuildsKnowledgeStackTrait. Including the directory in the unit suite let a "run unit suite with ::forProject deleted" litmus report five false positives. Pin it to integration where it belongs. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
=========================================
Coverage 99.73% 99.73%
Complexity 1903 1903
=========================================
Files 136 136
Lines 4882 4882
=========================================
Hits 4869 4869
Misses 13 13 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every file under
tests/Parity/builds the full production stack throughBuildsKnowledgeStackTrait. They belong in the integration suite — leaving them underunitmeant a "run unit suite with::forProjectdeleted" litmus check reported five false positives for tests that honestly need the stack.Two-line change to
phpunit.xml.dist:unitadds a second<exclude>,integrationadds a second<directory>. Running phpunit without a--testsuiteis unchanged.🤖 Generated with Claude Code