Skip to content

Move handler tests that build the full stack to tests/Integration #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Firehed merged 4 commits into from
Sep 30, 2026
Merged

Move handler tests that build the full stack to tests/Integration #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
551a5dd
Move and rename SignatureHelpHandlerTest to Integration suite
Firehed Sep 30, 2026
ff96f93
Move and rename DefinitionHandlerTest to Integration suite
Firehed Sep 30, 2026
59ba3d7
Move and rename HoverHandlerTest to Integration suite
Firehed Sep 30, 2026
f7e80a1
Move and rename CompletionHandlerTest to Integration suite
Firehed Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/Handler/CompletionHandlerTest.php → ...tion/CompletionHandlerIntegrationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

declare(strict_types=1);

namespace Firehed\PhpLsp\Tests\Handler;
namespace Firehed\PhpLsp\Tests\Integration;

use Firehed\PhpLsp\Capability\SessionCapabilities;
use Firehed\PhpLsp\Capability\SessionCapabilitiesProviderInterface;
Expand Down Expand Up @@ -41,6 +41,7 @@
use Firehed\PhpLsp\Resolution\TypeSource\NativeTypeSource;
use Firehed\PhpLsp\Tests\BuildsKnowledgeStackTrait;
use Firehed\PhpLsp\Tests\Completion\WiresCompletionSourceTrait;
use Firehed\PhpLsp\Tests\Handler\OpensDocumentsTrait;
use Firehed\PhpLsp\Tests\Parser\ProductionSyntaxSource;
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\Attributes\DataProvider;
Expand All @@ -61,7 +62,7 @@
#[CoversClass(ResolvedTypeOnly::class)]
#[CoversClass(SymbolCandidates::class)]
#[CoversClass(VariableCandidates::class)]
class CompletionHandlerTest extends TestCase
class CompletionHandlerIntegrationTest extends TestCase
{
use BuildsKnowledgeStackTrait;
use OpensDocumentsTrait;
Expand Down
5 changes: 3 additions & 2 deletions tests/Handler/DefinitionHandlerTest.php → ...tion/DefinitionHandlerIntegrationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

declare(strict_types=1);

namespace Firehed\PhpLsp\Tests\Handler;
namespace Firehed\PhpLsp\Tests\Integration;

use Firehed\PhpLsp\Document\DocumentManager;
use Firehed\PhpLsp\Domain\ComposerAutoloadMap;
Expand All @@ -16,14 +16,15 @@
use Firehed\PhpLsp\Resolution\SymbolResolver;
use Firehed\PhpLsp\Resolution\TypeSource\NativeTypeSource;
use Firehed\PhpLsp\Tests\BuildsKnowledgeStackTrait;
use Firehed\PhpLsp\Tests\Handler\OpensDocumentsTrait;
use Firehed\PhpLsp\Tests\Parser\ProductionSyntaxSource;
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\TestCase;

#[CoversClass(DefinitionHandler::class)]
#[CoversClass(ExpressionResolver::class)]
#[CoversClass(ResolvedTypeOnly::class)]
class DefinitionHandlerTest extends TestCase
class DefinitionHandlerIntegrationTest extends TestCase
{
use BuildsKnowledgeStackTrait;
use OpensDocumentsTrait;
Expand Down
5 changes: 3 additions & 2 deletions tests/Handler/HoverHandlerTest.php → ...tegration/HoverHandlerIntegrationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

declare(strict_types=1);

namespace Firehed\PhpLsp\Tests\Handler;
namespace Firehed\PhpLsp\Tests\Integration;

use Firehed\PhpLsp\Capability\SessionCapabilities;
use Firehed\PhpLsp\Capability\SessionCapabilitiesProviderInterface;
Expand All @@ -19,6 +19,7 @@
use Firehed\PhpLsp\Resolution\SymbolResolver;
use Firehed\PhpLsp\Resolution\TypeSource\NativeTypeSource;
use Firehed\PhpLsp\Tests\BuildsKnowledgeStackTrait;
use Firehed\PhpLsp\Tests\Handler\OpensDocumentsTrait;
use Firehed\PhpLsp\Tests\Parser\ProductionSyntaxSource;
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\Attributes\DataProvider;
Expand All @@ -27,7 +28,7 @@
#[CoversClass(ExpressionResolver::class)]
#[CoversClass(HoverHandler::class)]
#[CoversClass(ResolvedTypeOnly::class)]
class HoverHandlerTest extends TestCase
class HoverHandlerIntegrationTest extends TestCase
{
use BuildsKnowledgeStackTrait;
use OpensDocumentsTrait;
Expand Down
5 changes: 3 additions & 2 deletions tests/Handler/SignatureHelpHandlerTest.php → ...n/SignatureHelpHandlerIntegrationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

declare(strict_types=1);

namespace Firehed\PhpLsp\Tests\Handler;
namespace Firehed\PhpLsp\Tests\Integration;

use Firehed\PhpLsp\Document\DocumentManager;
use Firehed\PhpLsp\Handler\SignatureHelpHandler;
Expand All @@ -14,14 +14,15 @@
use Firehed\PhpLsp\Resolution\SymbolResolver;
use Firehed\PhpLsp\Resolution\TypeSource\NativeTypeSource;
use Firehed\PhpLsp\Tests\BuildsKnowledgeStackTrait;
use Firehed\PhpLsp\Tests\Handler\OpensDocumentsTrait;
use Firehed\PhpLsp\Tests\Parser\ProductionSyntaxSource;
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\TestCase;

#[CoversClass(ExpressionResolver::class)]
#[CoversClass(ResolvedTypeOnly::class)]
#[CoversClass(SignatureHelpHandler::class)]
class SignatureHelpHandlerTest extends TestCase
class SignatureHelpHandlerIntegrationTest extends TestCase
{
use BuildsKnowledgeStackTrait;
use OpensDocumentsTrait;
Expand Down
Loading