Suffix interfaces with Interface and traits with Trait - #554
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…rface Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Strip "Interface" suffix in OneRoutePerFactTest composite and layout checks so the family naming convention still holds when interfaces carry the suffix. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Update the phpstan baseline's ignored deprecation messages to match TypeFactory's renamed target. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The wider suffixes pushed a handful of lines past 120 characters and changed the alphabetical order of a few use blocks; wrap the lines and let phpcbf re-sort the imports. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The bulk perl pass rewrote every bare "Type" — including RFC section titles and general prose about the type concept. Undo those so the docs describe types, not the TypeInterface interface. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
=========================================
Coverage 99.72% 99.72%
Complexity 1909 1909
=========================================
Files 134 134
Lines 5005 5005
=========================================
Hits 4991 4991
Misses 14 14 ☔ View full report in Codecov by Harness. |
Firehed
commented
Sep 13, 2026
| * Context-specific type validity: | ||
| * | ||
| * | Type | Property | Parameter | Return | | ||
| * | TypeInterface | Property | Parameter | Return | |
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #552.
Every interface under
src/andtests/now ends inInterface, and every trait inTrait. A PHPCS rule pins the convention so future additions cannot skip the suffix.Layout
Generic.NamingConventions.InterfaceNameSuffixandGeneric.NamingConventions.TraitNameSuffixinphpcs.xml.dist.Typepass over-reached on.Notes
tests/Fixtures/*is out of scope (already excluded from PHPCS) so PSR examples stay intact.OneRoutePerFactTestcomposite and layout checks now strip theInterfacesuffix before comparing, soSyntaxSourceInterfaceand itsCompositeSyntaxSourcestill satisfy the same-family-namespace rule.TypeSourceInterfacedeprecation text; no baseline entries were added.🤖 Generated with Claude Code