Repository navigation
Store files byte-exact: no line-ending conversion at checkout - #78
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The repository now stores every file exactly as it is installed.
.gitattributesis* -text, so nothing is converted at checkout, and the Windows launchers (showtime.cmd,showtime.ps1,scripts/e2e-windows.ps1) are committed with CRLF line endings.scripts/check_release.pyand the structure test now fail on any attribute that converts content, on a Windows launcher with LF-only lines, and on a shell script containing CR bytes.Why
Plugin directories compare the installed files with the repository. A checkout that rewrites line endings made the two differ byte for byte on some systems. With no conversion, an installed plugin matches the repository exactly.
Behaviour
No behaviour change for users: the launchers run as before, and no code path changed.
Files
.gitattributes, the three Windows launchers,scripts/check_release.py,skills/showtime/tests/test_skill_structure.py, and a CHANGELOG entry.