Skip to content

fix(rp): add no-replug application recovery - #1304

Draft
zackees wants to merge 3 commits into
mainfrom
feat/rp-no-replug-recovery
Draft

fix(rp): add no-replug application recovery#1304
zackees wants to merge 3 commits into
mainfrom
feat/rp-no-replug-recovery

Conversation

@zackees

@zackees zackees commented Aug 19, 2026

Copy link
Copy Markdown
Member

Closes #1303

Coordinated with FastLED/FastLED#3908

Adds a target-bound RP recovery ladder that can return compatible firmware from application mode to BOOTSEL through the managed picotool binary. Forced reboot is always scoped by VID, PID, and serial identity.

Also adds fail-closed Windows recovery for the exact descriptor-failure sentinel. Recovery requires exact physical LocationPaths continuity, exact live sentinel VID/PID, and revalidation of the problem node before any exact child action; it never resets a hub, controller, or unrelated device.

Validation:

  • fbuild-core, fbuild-serial, fbuild-daemon, fbuild-deploy, and fbuild-cli tests and doc-tests passed
  • workspace lint and clippy passed
  • full-tree production VID/PID guard and its unit tests passed
  • exact-target, ambiguity, timeout/absence, phantom, wrong-sentinel, and descriptor-failure regressions passed
  • pre-push review clean after resolving the exact-sentinel safety finding

Hardware status:

  • fbuild 2.5.17 port scan confirms the target RP2350W is currently absent with only a stale phantom COM18 record
  • The live Windows code-43 node is on another physical root port and is correctly rejected as unrelated
  • Keep this PR draft until RP2350W hardware-in-the-loop recovery and 50 no-replug cycles are complete

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fdaaace3-854a-4ff0-90f7-7da4778479c6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

fix(rp): recover RP2350W deployment without USB replug

1 participant