Fix deprecated RLlib API and CNN policy definition in pistonball tutotial per #1253 - #1418
Open
jangroter wants to merge 4 commits into
Open
Fix deprecated RLlib API and CNN policy definition in pistonball tutotial per #1253 #1418jangroter wants to merge 4 commits into
jangroter wants to merge 4 commits into
Conversation
…defining conv_filters when specifying DefaultModelConfig)
Collaborator
|
@jangroter the pre-commit is failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The pistonball rllib tutorial (tutorials/ray/rllib_pistonball.py) used an old deprecated API stack for interfacing with RLlib, additionally, the custom CNN policy was registered, but never defined to be used by RLlib. This PR updates this tutorial to use the new API stack (since ray 2.56).
This also changes the way the CNN policy has to be defined, which is now a list of
[[num_out_channels, kernel, stride],...]. The resulting CNN policy should be identical to the one originally defined in the tutorial.One caveat: I do not have the required compute available right now to train a model, as a result there is no trained policy to observe, which is present in the original tutorial in the documentation.
Fixes #1253
Type of change
Screenshots
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)pytest -vand no errors are present.I did have errors for not having all ROMs installed through autoROM, but because my changes do not affect any environments I considered it non-critical to check
pytest -vhas generated that are related to my code to the best of my knowledge.