Some fixes for Static Mover Decals#1055
Open
SilverDorian46 wants to merge 9 commits into
Open
Conversation
… of the Decal's solids
maddie480-bot
added
the
1: review needed
microlith57
approved these changes
Mar 15, 2026
Wartori54
reviewed
Jun 23, 2026
Wartori54
left a comment
Wartori54
left a comment
Member
There was a problem hiding this comment.
Most of the PR looks good, just two nitpicks I'd like to argue about.
| /// </summary> | ||
| public List<Entity> ToAdd => toAdd; | ||
|
|
||
| public event Action OnEndOfAwake; |
Member
There was a problem hiding this comment.
If we are doing "post-awake" events, imo we should also do "pre-awake" events while we are at it.
Comment on lines
+318
to
+323
|
|
||
| ((patch_EntityList) (object) scene.Entities).OnEndOfAwake += () => { | ||
| if (staticMover?.Platform == null && CoreModule.Session.AttachedDecals.Contains(string.Format("{0}||{1}||{2}", Name, Position.X, Position.Y))) { | ||
| RemoveSelf(); | ||
| } | ||
| }; |
Member
There was a problem hiding this comment.
What is the use case that makes this valuable or required?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jumpThrusattribute.(int) X + y->(int) Y + yEntityList.PostAwakehas been implemented. this is called at the end ofEntityList.UpdateLists(), at which point it is exchanged fornull. any additions toPostAwakeduring its invocation will be called the next timeUpdateLists()is called.Awakehas been delegated to thePostAwakeevent.Decal.solids.Destroy-,Disable-, andEnableStaticMoversare included where appropriate.