Raising: forward the packed capture struct; distribute geps over selects - #3009
Closed
wsmoses wants to merge 1 commit into
Closed
Raising: forward the packed capture struct; distribute geps over selects#3009wsmoses wants to merge 1 commit into
wsmoses wants to merge 1 commit into
Conversation
Rebased onto main from the buffer-normalization stack. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016zErYp7upmqr4NHfhod9UD
wsmoses
force-pushed
the
pb/packed-scratch
branch
from
August 30, 2026 13:02
a2403d5 to
fa1e592
Compare
Member
Author
|
Recreated targeting main (content rebased): the stack lock prevents changing this PR's base. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #3007 (which stacks on #3006).
A not-quite-inlined device lambda packs its captures (DeviceTensors: pointer + sizes) into a stack struct and reads them back through typed views at constant offsets. Forward each load to the unique dominating store of its slot so the pointer-typed members never reach the raising as memory:
sizes[i]walked in a loop, as amemref.loador an affine map likes0 floordiv 4) resolved as a select chain over the constant-offset stores of their element type;Also distributeGepOverSelect: a side-selected view (
selectof byte offsets or of the pointers themselves feeding geps) distributes the gep and the memref view over the select so the buffer-branch expansion (#3007) can take over.This is what makes mfem's
bilininteg_vecdiffusion_pa.cppand the batched LOR kernels raise fully (#2968).🤖 Generated with Claude Code
https://claude.ai/code/session_016zErYp7upmqr4NHfhod9UD