Raise llvm.intr.abs to math.absi - #3001
Open
wsmoses wants to merge 1 commit into
Open
Conversation
The is_int_min_poison flag has no arith home; drop it. math.absi then raises generically (and to stablehlo.abs in arith-raise). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016zErYp7upmqr4NHfhod9UD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mfem's
general/array.cppreaches the raising withllvm.intr.abs(integer abs, fromstd::abson kernel indices), which nothing lowered to stablehlo. Raise it tomath.absiin the libdevice raising (droppingis_int_min_poison, which only weakens the semantics) and teach arith-raise to lowermath.absitostablehlo.abs.Part of #2968.
🤖 Generated with Claude Code
https://claude.ai/code/session_016zErYp7upmqr4NHfhod9UD