Repository navigation
Improve PixiJS utilities type safety: replace unsafe any casts with proper type guards for renderer and event handling - #36
Merged
Conversation
…ove unused eslint directive, and use next/image in slack notification
…roper type guards for renderer and event handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr closes #9
This pull request tightens TypeScript type safety in the PixiJS utility module (components/shared/pixi/utils.ts). The previous implementation used unsafe any casts and work‑arounds that effectively disabled type checking. The changes replace those casts with explicit type‑guard checks and proper typings, removing the need for @ts‑nocheck‑style suppression and preventing possible runtime crashes when upgrading or changing PixiJS canvas interfaces.
Key Changes
Why This Matters
Testing & Verification