Skip to content

chore: clean up Fallow dead code report#529

Merged
EnTRoPY0120 merged 1 commit into
mainfrom
chore/issue-522-fallow-cleanup
May 27, 2026
Merged

chore: clean up Fallow dead code report#529
EnTRoPY0120 merged 1 commit into
mainfrom
chore/issue-522-fallow-cleanup

Conversation

@EnTRoPY0120

@EnTRoPY0120 EnTRoPY0120 commented May 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove confirmed unused files from the current Fallow report
  • remove unused command and textarea UI component folders
  • document intentional OAuth/template false positives in Fallow config

Verification

  • npx fallow dead-code
  • pnpm format:check
  • pnpm lint
  • pnpm check
  • pnpm test
  • pnpm build
  • pnpm verify:repo:ci

Closes #522

Summary by CodeRabbit

  • Refactor

    • Removed search functionality and associated UI controls from the application
    • Removed resource tree navigation and visualization component
    • Removed resource inventory list view and display
    • Removed internal utility functions for event handling, storage management, and performance optimization
    • Removed backend use-case handlers and inventory parsing utilities
  • Chores

    • Updated application configuration for module exports and class member declarations

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR performs a substantial cleanup by removing multiple UI component implementations, Flux server use-case entry points, and utility modules from the codebase. The visible changes include updating Fallow configuration to ignore additional module exports and declare OAuth provider class members as used, plus removing the Textarea component export.

Changes

Cleanup and Configuration

Layer / File(s) Summary
Fallow configuration updates
.fallowrc.json
Extended ignoreExports to cover src/lib/templates/index.ts and src/lib/server/auth/oauth/index.ts with specific exports. Added usedClassMembers entry for IOAuthProvider methods: getAuthorizationUrl, validateCallback, getUserInfo, and refreshAccessToken.
UI component export cleanup
src/lib/components/ui/textarea/index.ts
Removed the Textarea component re-export from the barrel file.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • EnTRoPY0120/gyre#526: Both PRs modify .fallowrc.json to adjust Fallow's ignoreExports rules; this PR extends the baseline configuration established in that PR.
  • EnTRoPY0120/gyre#465: The main PR's removal of Flux server use-case entry points directly overlaps with a prior PR that introduced those same use-case modules.
  • EnTRoPY0120/gyre#369: The main PR's .fallowrc.json updates usedClassMembers for IOAuthProvider methods, which directly aligns with OAuth provider test coverage in that PR.

Poem

A rabbit hops through old code with glee, 🐰
Sweeping components away clean and free,
OAuth's dance now properly declared,
The fallow fields are tidied and cared,
Cleanup complete—more clarity to see! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: clean up Fallow dead code report' accurately describes the main change: removing confirmed unused files and documenting intentional false positives in Fallow configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/issue-522-fallow-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Docker Build Completed

Status: Success
Platform: linux/amd64,linux/arm64

Security Scan

Trivy vulnerability scan completed. Check the workflow logs for details.

Note: Images are not pushed for pull requests. Merge to main to publish.

@EnTRoPY0120

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@EnTRoPY0120 EnTRoPY0120 self-assigned this May 27, 2026
@EnTRoPY0120
EnTRoPY0120 merged commit e54249c into main May 27, 2026
6 checks passed
@EnTRoPY0120
EnTRoPY0120 deleted the chore/issue-522-fallow-cleanup branch May 27, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove or suppress confirmed dead files and exports from Fallow report

1 participant