fix: quiet benign duplicate-HTLC EF errors and disable sensitive-data logging in prod - #544
Open
markettes wants to merge 2 commits into
Open
fix: quiet benign duplicate-HTLC EF errors and disable sensitive-data logging in prod#544markettes wants to merge 2 commits into
markettes wants to merge 2 commits into
Conversation
Contributor
|
Nack, can't we handle this without removing logging? is the unique really what I thought it should be? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production logs were being flooded with large
Error-level entries every time aduplicate
ForwardingHtlcEventwas inserted (composite PK collision, Postgres23505).These duplicates are expected and already handled:
ForwardingHtlcEventRepository.UpsertAsynccatches the unique-violation and skips the row. But two things made them noisy anyway:
catch. During the failing command EFemits
RelationalEventId.CommandErrorandCoreEventId.SaveChangesFailedatError— a fullSQL command + parameter dump and a complete stack trace — before the exception ever reaches
our handler. Serilog pins
MicrosofttoWarning, but these areError, so they passed through.AddDbContextFactory<ApplicationDbContext>calledEnableSensitiveDataLogging()+EnableDetailedErrors()unconditionally, dumping raw parametervalues (node pubkeys, HTLC amounts, peer aliases) into every failed-command log — both noise
and a privacy concern.