Repository navigation
Bump Moq from 4.20.70 to 4.21.0 - #508
Open
DavidJGapCR wants to merge 1 commit into
Open
DavidJGapCR wants to merge 1 commit into
DavidJGapCR wants to merge 1 commit into
Conversation
Recreates #505, which Dependabot closed as "no longer updatable" even though main still pins 4.20.70. Moq 4.21.0 enables nullable annotations, so the It.IsAnyType matcher value is now nullable. Add a null check in the logger Verify predicate (?. is not allowed in expression trees) to keep the DBTests building with warnings as errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DavidJGapCR
added
dependencies
Contributor
Test Results 12 files 12 suites 57s ⏱️ Results for commit e7186bd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreates #505, which Dependabot closed with "Looks like Moq is no longer updatable". That's incorrect:
mainstill pins 4.20.70 inApplication/Directory.Packages.props, and it's referenced directly byDBTests,V1.DBTestsandV3.DBTests. (Note: #191 had already moved Moq to 4.20.72, but #237 appears to have reverted it to 4.20.70.)Changes
Moq4.20.70 → 4.21.0 (release notes). The package contains onlylib/assemblies (no analyzers or build targets) and depends only onCastle.Core/System.Threading.Tasks.Extensions.packages.lock.jsonfor the 3 DB test projects (same file set as Bump Moq from 4.20.70 to 4.21.0 #505).EducationOrganizationServiceTests.cs(DBTestsandV3.DBTests): Moq 4.21.0 enables nullable annotations, so theIt.Is<It.IsAnyType>predicate value is now nullable (CS8602 as error). Added av != null &&guard;?.andis not nullaren't allowed in expression trees.Verification
dotnet restore --force-evaluate+ Release build: 0 warnings, 0 errors.🤖 Generated with Claude Code