No longer need to allow for C/E at end of time period#4097
Open
billsacks wants to merge 1 commit into
Open
Conversation
Needs to wait for the compset changes in ESCOMP/CESM#407 and ESCOMP/CAM#1584.
billsacks
added
the
blocked: dependency
Member
Author
|
Blocked / dependency: Needs to wait for the compset changes in ESCOMP/CESM#407 and ESCOMP/CAM#1584 before coming in to a CESM alpha tag or a CAM tag. |
ekluzek
approved these changes
Jun 23, 2026
ekluzek
left a comment
ekluzek
left a comment
Contributor
There was a problem hiding this comment.
I did some checking to make sure there wasn't anywhere else to change, and didn't find anything. So this will be good to go, once the other changes are in.
billsacks
added a commit
to ESCOMP/CESM
that referenced
this pull request
Jul 16, 2026
Change long name specifier for CO2 forcings ### Description of changes We have decided to use the CESM2 scheme for this. See ESCOMP/CMEPS#658 for some relevant discussion. I did this with two regex search & replaces: (1) Concentration-driven: - Search for `<lname>([^_]*)C_(.*)</lname>` - Replace with `<lname>$1_$2_BGC%BDRD</lname>` - Update 2026-06-18: we later decided to remove the `_BGC%BDRD` from these compsets (2) Emissions-driven: - Search for `<lname>([^_]*)E_(.*)</lname>` - Replace with `<lname>$1_$2_BGC%BPRP</lname>` **This should be coordinated with the following component changes:** - **This should come in at the same time as the CAM PR that changes compsets similarly: ESCOMP/CAM#1584 - Ideally, [this CTSM PR](ESCOMP/CTSM#4097) and [this CDEPS PR](ESCOMP/CDEPS#413) would come in at the same time. However, it's safe for either or both of them to come later. (The reason that it's ideal for them to come in at the same time is just to ensure that they are bit-for-bit across a wide range of configurations - so it would be ideal to include them in the bit-for-bit prealpha testing that is planned for this PR.) - For emissions-driven compsets to work correctly, this also needs the changes in [this CAM PR](ESCOMP/CAM#1581); however, emissions-driven compsets currently aren't tested, so it's safe for that CAM PR to come in later ### Specific notes Contributors other than yourself, if any: none Fixes: none User interface changes?: No **Expected answer changes:** Bit-for-bit for concentration-driven compsets (which are the only ones currently tested). (`B1850E*` and `BHISTE*` compsets would change answers, but we currently don't test them.) Testing performed (automated tests and/or manual tests): Ran these tests; they pass and are bit-for-bit: - ERS_Ld5.ne30pg3_t232.B1850C_LTso.derecho_intel.allactive-defaultio - ERS_Ld5.ne30pg3_t232.BHISTC_LTso.derecho_intel.allactive-defaultio - ERS_D_Ld3.ne30pg3_t232.B1850C_LTso.derecho_intel.allactive-defaultio
Member
Author
|
The dependent PRs have been merged. |
billsacks
marked this pull request as ready for review
July 21, 2026 04:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
We are changing the compset specification to no longer have C/E at the end of the time period, so we can remove the parsing of this from compset regexes.
Needs to wait for the compset changes in
ESCOMP/CESM#407 and
ESCOMP/CAM#1584.
Specific notes
Contributors other than yourself, if any: none
CTSM issues resolved or otherwise addressed, if any:
Any user interface changes (namelist or namelist defaults changes)? no
Testing planned or performed, if any:
none yet
Requirements before merge: