-
Notifications
You must be signed in to change notification settings - Fork 720
feat: 店舗設定に構造化データ拡張項目を追加 (sameAs/foundingDate 等) (#6147) #6957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ttokoro20240902
wants to merge
7
commits into
4.4
Choose a base branch
from
feature/issue-6147-baseinfo-schema
base: 4.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2f364a6
ref: #6136 Organization, Websiteのマークアップを追加
tao-s 2c79b6b
fix(schema): サイト構造化データを json_ld フィルタ経由の安全な出力に変更
ttokoro20240902 b9d9b26
feat(schema): 店舗設定に構造化データ拡張項目を追加(sameAs/foundingDate 等)
ttokoro20240902 4e3a5c0
feat(schema): 営業時間(OpeningHoursSpecification)を店舗設定に追加
ttokoro20240902 4e97130
feat(schema): 構造化データ拡張項目のバリデーション強化とテスト追加
ttokoro20240902 c4e64cb
fix(schema): CodeRabbit指摘対応(number_of_employees上限・単純カラムmigration削除)
ttokoro20240902 026a317
Merge branch '4.4' into feature/issue-6147-baseinfo-schema
ttokoro20240902 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /* | ||
| * This file is part of EC-CUBE | ||
| * | ||
| * Copyright(c) EC-CUBE CO.,LTD. All Rights Reserved. | ||
| * | ||
| * http://www.ec-cube.co.jp/ | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace DoctrineMigrations; | ||
|
|
||
| use Doctrine\DBAL\Platforms\AbstractMySQLPlatform; | ||
| use Doctrine\DBAL\Schema\Schema; | ||
| use Doctrine\Migrations\AbstractMigration; | ||
|
|
||
| /** | ||
| * 店舗情報の構造化データ(JSON-LD / schema.org)拡張用カラムを dtb_base_info に追加する. | ||
| * | ||
| * - same_as : SNS 等の公式 URL(改行区切り, Organization.sameAs) | ||
| * - founding_date : 稼働開始日(Organization.foundingDate) | ||
| * - number_of_employees: 従業員数(Organization.numberOfEmployees) | ||
| * - copyright_year : 著作権表示の開始年(WebSite.copyrightYear) | ||
| * - site_image : サイト代表画像 URL(Organization.image) | ||
| */ | ||
| final class Version20260722000000 extends AbstractMigration | ||
| { | ||
| public const NAME = 'dtb_base_info'; | ||
|
|
||
| public function up(Schema $schema): void | ||
| { | ||
| if (!$schema->hasTable(self::NAME)) { | ||
| return; | ||
| } | ||
|
|
||
| $table = $schema->getTable(self::NAME); | ||
| if ($table->hasColumn('same_as')) { | ||
| return; | ||
| } | ||
|
|
||
| // TEXT 型は MySQL では LONGTEXT にマップされるため、schema:update との差分を避けて分岐する | ||
| $textType = $this->connection->getDatabasePlatform() instanceof AbstractMySQLPlatform ? 'LONGTEXT' : 'TEXT'; | ||
|
|
||
| $this->addSql('ALTER TABLE dtb_base_info ADD same_as '.$textType.' DEFAULT NULL'); | ||
| $this->addSql('ALTER TABLE dtb_base_info ADD founding_date DATE DEFAULT NULL'); | ||
| $this->addSql('ALTER TABLE dtb_base_info ADD number_of_employees INT DEFAULT NULL'); | ||
| $this->addSql('ALTER TABLE dtb_base_info ADD copyright_year INT DEFAULT NULL'); | ||
| $this->addSql('ALTER TABLE dtb_base_info ADD site_image VARCHAR(255) DEFAULT NULL'); | ||
| } | ||
|
|
||
| public function down(Schema $schema): void | ||
| { | ||
| if (!$schema->hasTable(self::NAME)) { | ||
| return; | ||
| } | ||
|
|
||
| $table = $schema->getTable(self::NAME); | ||
| if (!$table->hasColumn('same_as')) { | ||
| return; | ||
| } | ||
|
|
||
| $this->addSql('ALTER TABLE dtb_base_info DROP COLUMN same_as'); | ||
| $this->addSql('ALTER TABLE dtb_base_info DROP COLUMN founding_date'); | ||
| $this->addSql('ALTER TABLE dtb_base_info DROP COLUMN number_of_employees'); | ||
| $this->addSql('ALTER TABLE dtb_base_info DROP COLUMN copyright_year'); | ||
| $this->addSql('ALTER TABLE dtb_base_info DROP COLUMN site_image'); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.