Skip to content

Re-enable tc_analysis tests#838

Draft
forsyth2 wants to merge 1 commit into
mainfrom
re-enable-tc-analysis-tests
Draft

Re-enable tc_analysis tests#838
forsyth2 wants to merge 1 commit into
mainfrom
re-enable-tc-analysis-tests

Conversation

@forsyth2

@forsyth2 forsyth2 commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Objectives:

  • Re-enable tc_analysis sections in the weekly test templates.
  • Re-enable tc_analysis sets for e3sm_diags in the the weekly test templates.

This will allow us to test #828 more thoroughly. After completing testing of that PR, we will determine whether to merge this PR or close it (and hopefully re-open/merge it in the future once tc_analysis is fully working again).

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • a new feature: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

Small Change

  • To merge, I will use "Squash and merge". That is, this change should be a single commit.
  • Logic: I have visually inspected the entire pull request myself.
  • Pre-commit checks: All the pre-commits checks have passed.

@forsyth2 forsyth2 self-assigned this Jun 2, 2026
@forsyth2 forsyth2 added Testing Files in `tests` modified semver: small improvement Small improvement (will increment patch version) labels Jun 2, 2026
@forsyth2

forsyth2 commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author
Setup steps
git fetch upstream main
git checkout -b re-enable-tc-analysis-tests upstream/main

git grep -B 1 "\[tc_analysis\]" tests/integration/template_weekly_*.cfg
# Check for commented out lines
# Re-enable all tc_analysis tasks
git grep -B 1 "\[tc_analysis\]" tests/integration/template_weekly_*.cfg
# Good, nothing remains commented out

# We still need to add tc_analysis back into the e3sm_diags sets though.
# Resolve those and then confirm nothing was missed with:
git grep -n "TODO: Add \"tc_analysis\" back in" tests/integration/template_weekly_*.cfg
# Good, no results

lcrc_conda
rm -rf build
conda clean --all --y
conda env create -f conda/dev.yml -n zppy-re-enable-tc-analysis-20260602
conda activate zppy-re-enable-tc-analysis-20260602
git add -A
pre-commit run --all-files
git add -A
git commit -m "Re-enable tc_analysis tests"
git push upstream re-enable-tc-analysis-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: small improvement Small improvement (will increment patch version) Testing Files in `tests` modified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant