Skip to content

DYN-8693 Fix List.SortIndexByValue to accept integers and mixed numeric types #17053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Open

DYN-8693 Fix List.SortIndexByValue to accept integers and mixed numeric types #17053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
972438a
Initial plan
Copilot Apr 15, 2026
e82c779
DYN-8693 Fix List.SortIndexByValue to accept integers and other compa…
Copilot Apr 15, 2026
b69fa14
DYN-8693 Use IList parameter for backward compat; fix stable-sort tes…
Copilot Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/Libraries/CoreNodes/List.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,15 +244,12 @@ public static IList Reorder(IList list, IList indices)
/// <returns name="int[]">The indices of the items in the sorted list</returns>
/// <search>sort,index,value</search>
[IsVisibleInDynamoLibrary(true)]
public static IEnumerable SortIndexByValue(List<double> list)
public static IEnumerable SortIndexByValue(IList list)
{
List<Tuple<int, double>> tupleList = new List<Tuple<int, double>>();
for (int i = 0; i < list.Count; i++)
{
tupleList.Add(new Tuple<int, double>(i, list[i]));
}
tupleList = tupleList.OrderBy(x => x.Item2).ToList();
IEnumerable<int> newList = tupleList.OrderBy(x => x.Item2).Select(y => y.Item1);
IEnumerable<int> newList = list.Cast<object>()
.Select((value, index) => new Tuple<int, object>(index, value))
.OrderBy(x => x.Item2, new ObjectComparer())
.Select(y => y.Item1);
return newList;
}

Expand Down
14 changes: 14 additions & 0 deletions test/Libraries/CoreNodesTests/ListTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,20 @@ public static void SortIndexByValue()
{
Assert.AreEqual(new ArrayList { 4, 2, 3, 1, 0 }, List.SortIndexByValue(new List<double> { 8.0, 4.1, 2.0, 4.0, 0.0 }));
}

[Test]
[Category("UnitTests")]
public static void SortIndexByValue_WithIntegers()
{
Assert.AreEqual(new ArrayList { 4, 2, 1, 3, 0 }, List.SortIndexByValue(new List<int> { 8, 4, 2, 4, 0 }));
}

[Test]
[Category("UnitTests")]
public static void SortIndexByValue_WithMixedNumericTypes()
{
Assert.AreEqual(new ArrayList { 4, 2, 1, 3, 0 }, List.SortIndexByValue(new List<object> { 8.0, 4, 2.0, 4, 0 }));
}

[Test]
[Category("UnitTests")]
Expand Down
Loading