Repository navigation
fix: online state, offline device delete, Node.js 26 tests, @iobroker/testing 6 - #880
Merged
Merged
Conversation
…/testing 6
- The online state of a device that cannot be initialised was written as
the text '{"val":false,"ack":true}', which js-controller rejected with
"has to be type boolean but received type string" (#788, #794). It is
written as false again and the device is marked disconnected. Based on
#792 by @arteck.
- "Unable to initialise" is logged as a warning once per outage, later
attempts for a device that stays offline go to debug (#788).
- Deleting a device from the instance settings looked the object up by the
device's friendly name instead of its MAC address, and devices offline
since adapter start have no name in memory, so it always failed with
"Device with IP ... not found" (#787). It now uses the MAC and falls back
to the device objects for devices not in memory.
- delDevice: instance number in the ID prefix may have more than one digit.
- check-copilot-template.yml looked for open issues labelled both
copilot-setup and automation, but update issues are labelled
template-update, so a new issue was opened every week. It now matches
on automation only.
- adapter-tests matrix covers 22.x, 24.x and 26.x (repo checker E3025, #872)
- @iobroker/testing ^5.3.0 -> ^6.3.0 (repo checker E0036)
- concurrency block in the checker's expected form (W3009)
- README: removed the link to docs/DEPLOYMENT_SETUP.md, which does not
exist (#876)
Supersedes #792 and #873.
Co-authored-by: arteck <6681528+arteck@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CnLX1Q3mvPvMb6JY4hHKfL
This was referenced Oct 1, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the open online-state and device-delete bugs and the two repository-checker errors in #870, which are blocking the next stable update (#869).
Bug fixes
_onlinewritten as text. When a device couldn't be initialised,getDeviceJSONpassed{ val: false, ack: true }tocreate_state, which wrote it as the string'{"val":false,"ack":true}'. js-controller then loggedhas to be type "boolean" but received type "string", which is visible in the logs posted in Log voll seit letzter stable #788. It now writesfalseand marks the device disconnected. This is based on fix online state #792 by @arteck (co-author). That PR has merge conflicts, so I carried over the fix rather than itsmaxRetries = 0change, which belongs to the feature request add maxRetries per device #793.deleteDevicemessage usedthis.devices[ip].name(the friendly name) as the object ID. Device objects are keyed by MAC address, and a device that has been offline since adapter start has nonamein memory, so deletion always failed withDevice with IP … not found. It now uses the MAC address and falls back to the device objects when the device isn't in memory.delDevicealso accepts instance numbers above 9.docs/DEPLOYMENT_SETUP.md, which doesn't exist and broke the iobroker.net docs build. A short paragraph about trusted publishing replaces it.CI / repository checker
@iobroker/testinggoes from^5.3.0to^6.3.0.check-copilot-template.ymllooked for open issues labelledcopilot-setupandautomation, but update issues are labelledtemplate-update, so the check never found them and opened a new one every Sunday. It now matches onautomation. I closed the 30 older duplicates and left 🤖 Update ioBroker Copilot Instructions Template #879 open.Tests (local, Node 22)
npm run lint: 0 errors (3anywarnings that were already there)npm run test:integration: the adapter starts with @iobroker/testing 6W3032 (the tag run for v0.9.2 failed) clears with the next successful release.
🤖 Generated with Claude Code
https://claude.ai/code/session_01CnLX1Q3mvPvMb6JY4hHKfL
Generated by Claude Code