chore(deps): update react monorepo to v19#1325
Conversation
✅ Deploy Preview for doist-typist ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
doistbot
left a comment
There was a problem hiding this comment.
This PR updates the React monorepo dependencies and widens the peer dependency ranges to introduce support for React 19. Expanding compatibility to the latest React release is a great step forward for the library's longevity. However, there are a few configuration and testing misalignments to address, including regenerating the out-of-sync lockfile, updating the @doist/reactist development dependency to resolve version conflicts, and ensuring the CI test suite covers all versions advertised in the widened peer dependency range.
| "publint": "0.3.19", | ||
| "react": "18.3.1", | ||
| "react-dom": "18.3.1", | ||
| "react": "19.2.6", |
There was a problem hiding this comment.
[P1] package-lock.json still pins the root react, react-dom, @types/react, @types/react-dom, and peer ranges to the old 18.x values. Leaving this file out of sync with package.json will make npm ci fail; please regenerate and commit the lockfile with this version bump.
| "micromark-extension-gfm-strikethrough": "^2.0.0", | ||
| "react": "^17.0.0 || ^18.0.0", | ||
| "react-dom": "^17.0.0 || ^18.0.0", | ||
| "react": "^17.0.0 || ^18.0.0 || ^19.0.0", |
There was a problem hiding this comment.
[P1] This advertises React 19 support, but the repo still depends on @doist/reactist@30.1.4 for Storybook, and that package currently declares react/react-dom ^17 || ^18 in the lockfile. Please upgrade or remove that dependency before widening the published peer range, otherwise the React 19 setup remains unsupported in development.
| "micromark-extension-gfm-strikethrough": "^2.0.0", | ||
| "react": "^17.0.0 || ^18.0.0", | ||
| "react-dom": "^17.0.0 || ^18.0.0", | ||
| "react": "^17.0.0 || ^18.0.0 || ^19.0.0", |
There was a problem hiding this comment.
[P2] This widens the supported peer range to React 19, but npm test in CI still runs only against the single React version from devDependencies—which this PR also bumps to 19. That means the suite no longer exercises React 18 at all while we still advertise ^17 || ^18 || ^19 support here. Add a React-version test matrix/smoke test (at least 18 and 19), or narrow the peer range to the versions we actually verify.
649346a to
7cf83bb
Compare
c35b6f1 to
f50d07c
Compare
09afd23 to
ee35844
Compare
b0893c2 to
a7e7d86
Compare
ec89b39 to
d8b1bfd
Compare
622c1db to
295e7a6
Compare
295e7a6 to
27bbf52
Compare
This PR contains the following updates:
18.3.31→19.2.1718.3.7→19.2.3Configuration
📅 Schedule: (UTC)
* * * * 1-5)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.