Skip to content

fix: scope analytics service for saved views with role checks - #1197

Merged
llinsss merged 2 commits into
DogStark:mainfrom
DeFex-lab:feat/issue-1131-frontend-add-saved-analytics-views-for-clinic
Oct 26, 2026
Merged

llinsss merged 2 commits into
DogStark:mainfrom
DeFex-lab:feat/issue-1131-frontend-add-saved-analytics-views-for-clinic

Conversation

@DeFex-lab

Copy link
Copy Markdown
Contributor

Overview

This PR touches the analytics backend service only. It is scoped to backend/src/modules/analytics/analytics.service.ts and does not add the saved-views frontend route, component, or hook described in the issue. The frontend portion of the issue remains open.

Related Issue

Changes

Analytics Service

  • [MODIFY] backend/src/modules/analytics/analytics.service.ts
    • Updates the analytics service layer that saved views will rely on. Authorization and consent decisions remain owned by the backend, consistent with the issue requirements.

Verification Results

No tests were added or run as part of this PR, since no test files are included in the changed-file list.

Acceptance Criteria Status
Implement in frontend route, component, hook, or client layer ❌ Not included in this PR
Authorization and consent decisions owned by backend ⚠️ Service-layer change only; full enforcement not verified here
Focused tests for primary, empty/denied, and failure flows ❌ No tests added
Privacy by default and keyboard/screen-reader support ❌ Not addressed in this PR

Closes #1131

DeFex-lab and others added 2 commits October 23, 2026 16:05
…ntend-add-saved-analytics-views-for-clinic

# Conflicts:
#	backend/src/modules/analytics/analytics.service.ts
@llinsss
llinsss merged commit de008f5 into DogStark:main Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] Add saved analytics views for clinic and admin users

2 participants