Repository navigation
Abspos: apply safe static alignment within the IMCB - #1267
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Match Chrome/WPT for
safestatic alignment when the containing block is outside the originating grid or flex container.Context
With both insets
auto, check margin-box overflow against the existing inset-modified containing block (IMCB), not the static-position rectangle. On overflow, align to the containing block's logical start within the IMCB; otherwise retain the original static alignment. Sizing, margins, non-auto inset paths, default/unsafe alignment, and the standaloneresolve_static_offsetAPI are unchanged. Nine net production lines; no new allocation or per-node storage.This intentionally chooses Chrome's interpretation of CSSWG #11934, which remains unresolved; Firefox and Safari fail the two tentative grid tests too. Independent of the collapsed-gutter fix in #1266.
Validation:
tentativeand comments link their upstream WPTs or related tentative coverage. All 12 generated variants fail before and pass after.cargo test --all-features: 185 unit, 146 handwritten, 6377 generated, and 5 doctests passed (4 existing ignored). No new non-generated tests.safe-outer-cb-001and003, and flexsafe-outer-cb-003, now pass.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/87b105dd2f0549cf9edddc0f14d12ea0
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/87b105dd2f0549cf9edddc0f14d12ea0?variant=devin-insiders
Requested by: @nicoburns