Repository navigation
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Contributions: Code and this description were written by Devin (an LLM agent). This PR is kept for reference and is not expected to be merged.
This PR is stacked on #62. It adds
TreeBuilder pushandTreeBuilder buildbenchmarks toparley_bench, which were used to measure the effect of removinguncommitted_textin #62.TreeBuilder pushpushes a sample text throughpush_style_span,push_textandpop_style_spanand does no shaping. It varies the number of chars perpush_textcall (1 or 10), the number of pushes per span (1, 8 or 10) and theWhiteSpaceCollapsemode.TreeBuilder builddoes the same pushes, followed bybuild_into, which includes shaping.Tango results against the buffered builder are in #62.
Changelog: None
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/4641a2bf5eca4d4fb140d16886180423
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/4641a2bf5eca4d4fb140d16886180423?variant=devin-insiders
Requested by: @nicoburns