Repository navigation
Conversation
ealmloff
force-pushed
the
support-aria-label-and-labelledby
branch
from
September 26, 2026 04:19
ac487c3 to
3bb80d6
Compare
hovinen
force-pushed
the
support-aria-label-and-labelledby
branch
2 times, most recently
from
October 23, 2026 07:06
166a9a4 to
1c89013
Compare
hovinen
force-pushed
the
support-aria-label-and-labelledby
branch
from
October 24, 2026 13:39
1c89013 to
0be006c
Compare
hovinen
changed the title
Blitz sets the accesskit label of a node according to the accessible name computation of the W3C specification: `aria-label`, `aria-labelledby`, `<label>` elements, alternative text, and name from content. Read the label from the node instead of recomputing it here, and remove the `aria_tree` module, which implemented only a subset of the algorithm. The lookup of nodes by ID, which is all that remains of it, moves into `query`. This depends on the Blitz branch which provides this behavior. As per step 2A of the specification, the content of a hidden element does not provide its name. So remove the test and the examples which relied on matching hidden elements by that name.
hovinen
force-pushed
the
support-aria-label-and-labelledby
branch
from
October 30, 2026 14:04
0be006c to
cec1fec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leverages DioxusLabs/blitz#1223 to greatly simplify how the accesssible name is accessed. The existing partial implementation of the accessible name algorithm is removed as redundant.
In particular, this allows selecting elements whose accessible name is given by the
aria-labeloraria-labelledbyattributes.Concretely, this is needed to reimplement some more of the Playwright tests of Dioxus components using dioxus-test.