Repository navigation
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Node::hit_innerrecursed into children whenever the point was inside the node's scrollable overflow or content rect, even when the node clips. So content overflowing anoverflow: hiddenancestor stayed clickable in the region that was clipped away. Example: DuckDuckGo's.frm__select { overflow: hidden; width: 145px }wrapsselect { width: 140% }, so clicks to the right of the visible box still opened the select (found while testing #1321).Descendant hits are now clipped per axis at the padding edge, plus
overflow-clip-margin, whenever a node clips on that axis. Scroll offsets and transforms are handled. Hoisted (positioned) descendants walk their containing-block chain, so an abspos child whose containing block is outside the clipping element still escapes the clip, matching paint. The containment predicate is extracted fromblitz-paint/src/render.rsand shared; paint behaviour is unchanged.Local WPT:
css/css-overflow/overflow-clip-margin-hit-testing.htmlgoes FAIL → PASS. The rest ofcss/css-overflowand theelementFromPoint*/elementsFromPoint*tests are unchanged.Not changed:
clip-pathhit-testing.overflow-clip-margin.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/55516ded5eb14b35b0c9bca6b400ca61
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/55516ded5eb14b35b0c9bca6b400ca61?variant=devin-insiders
WPT results
Subtests: 6 newly passing, 0 newly failing (net +6).
Subtest changes by area (7 areas)
Full diff (5 changed tests)
Generated by the WPT workflow.