Repository navigation
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin Taffy to DioxusLabs/taffy#1288, making
compute_block_align_content_offsetdefault to safe overflow alignment while preserving explicitunsafe. This covers Taffy's block layout and callers laying out line boxes externally; Flexbox/Grid defaults are unchanged.Preserve explicit
unsafeinstylo_taffy::convert::content_alignment: previously it was discarded, relying on Taffy's default being unsafe. Changing the default exposed seven WPT regressions. Add a conversion regression test covering default, safe, and unsafe end/center/flex-end for block, inline-block, table-cell, flex, and grid displays.Full CSS+SVG WPT CI now matches main: all seven regressions are restored, with no new passes or failures. Blitz already supplies safe defaults for block containers. The original pin's table-cell gain also disappears, since it depended on losing explicit
unsafe; that subtest remains an existing failure, requiring a table-cell-specific fix.Formatting, workspace check and Clippy, and
blitz-dom/stylo_taffy/blitz-teststests pass. The full release local WPT A/B (36,274 tests) also has no regressions relative to main.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/3c766f9ec5f343c3b0c65e447a5ca7a6
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/3c766f9ec5f343c3b0c65e447a5ca7a6?variant=devin-insiders
Requested by: @nicoburns
WPT results
No changes in test results compared to
main.Generated by the WPT workflow.