Repository navigation
Synchronize Taffy pin with main (percentage flex-basis fix already landed) - #1148
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
staging-devin-ai-integration
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The percentage flex-basis fix from DioxusLabs/taffy#1286 is already included in Blitz main's Taffy pin,
2d936b7701f64b0fe95e50f1bfdcfc65a9f88f6f.Merged current main into this branch and retained that pin rather than downgrading Taffy to the former development commit. The branch now has no file differences from main, so no additional dependency change is needed.
Verified that the merged Taffy flexbox implementation matches the reviewed fix, that the Taffy main pin includes its squash commit, and that the resolved branch is byte-identical to Blitz main. Formatting and locked Cargo metadata validation pass.
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/23582270f23c44f89d495d1762c2c5f1
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/23582270f23c44f89d495d1762c2c5f1?variant=devin-insiders
Requested by: @nicoburns
WPT results
No changes in test results compared to
main.Generated by the WPT workflow.