Repository navigation
Bump Taffy (named lines resolved once, before the grid size estimate) (Taffy #1259) - #1072
Merged
nicoburns merged 1 commit intoOct 8, 2026
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This was referenced Oct 6, 2026
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791249287-taffy-grid-size-estimate-named-lines
branch
12 times, most recently
from
October 8, 2026 13:51
a88fe13 to
9272b18
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791249287-taffy-grid-size-estimate-named-lines
branch
from
October 8, 2026 14:05
9272b18 to
1f2ae47
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791249287-taffy-grid-size-estimate-named-lines
branch
2 times, most recently
from
October 8, 2026 14:16
d96c63b to
675f2b4
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791249287-taffy-grid-size-estimate-named-lines
branch
from
October 8, 2026 14:27
675f2b4 to
d4ba610
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps Taffy to current
main(4f18a82e), which adds DioxusLabs/taffy#1259 on top of the previously pinnedd7cb4642. Items placed with named grid lines no longer create implicit tracks that nothing occupies, and the named lines in each grid item'sgrid-row/grid-columnare resolved once per layout, before the grid size estimate, instead of again during placement (Taffy's grid benchmarks are 2–15% faster, most for grids using named lines/areas). No Blitz code changes.WPT
css/css-grid(local, vsmain): 11011 → 11013 subtests passing, no regressions.placement/grid-placement-unknown-named-grid-line-001.htmlplacement/grid-placement-negative-position-resolution-001.htmlLink to Devin session: https://dioxus.staging.devinenterprise.com/sessions/2530fd358d4f4736bec3c4ac9accefdb
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/2530fd358d4f4736bec3c4ac9accefdb?variant=devin-insiders
Requested by: @nicoburns
WPT results
Subtests: 2 newly passing, 0 newly failing (net +2).
Subtest changes by area (3 areas)
Full diff (2 changed tests)
Generated by the WPT workflow.