Skip to content

Bump Taffy (named lines resolved once, before the grid size estimate) (Taffy #1259) - #1072

Merged
nicoburns merged 1 commit into
mainfrom
devin/1791249287-taffy-grid-size-estimate-named-lines
Oct 8, 2026
Merged

nicoburns merged 1 commit into
mainfrom
devin/1791249287-taffy-grid-size-estimate-named-lines

Conversation

@nicoburns

@nicoburns nicoburns commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Summary

Bumps Taffy to current main (4f18a82e), which adds DioxusLabs/taffy#1259 on top of the previously pinned d7cb4642. Items placed with named grid lines no longer create implicit tracks that nothing occupies, and the named lines in each grid item's grid-row/grid-column are resolved once per layout, before the grid size estimate, instead of again during placement (Taffy's grid benchmarks are 2–15% faster, most for grids using named lines/areas). No Blitz code changes.

WPT css/css-grid (local, vs main): 11011 → 11013 subtests passing, no regressions.

Test Newly passing subtests
placement/grid-placement-unknown-named-grid-line-001.html 1
placement/grid-placement-negative-position-resolution-001.html 1

Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/2530fd358d4f4736bec3c4ac9accefdb
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/2530fd358d4f4736bec3c4ac9accefdb?variant=devin-insiders
Requested by: @nicoburns

WPT results

Subtests: 2 newly passing, 0 newly failing (net +2).

Subtest changes by area (3 areas)
+ css           | +2 (+2 / -0) | 59.46% ->  59.46% (+0.00%) | 117594 -> 117596 / 197777
+   css-grid    | +2 (+2 / -0) | 77.47% ->  77.48% (+0.01%) |  13612 ->  13614 /  17570
+     placement | +2 (+2 / -0) | 99.40% -> 100.00% (+0.60%) |    331 ->    333 /    333
Full diff (2 changed tests)
+ FAIL => PASS  [16/16]  +1  css/css-grid/placement/grid-placement-negative-position-resolution-001.html
+ FAIL => PASS  [17/17]  +1  css/css-grid/placement/grid-placement-unknown-named-grid-line-001.html

Generated by the WPT workflow.

@staging-devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access that start with 'Devin'.

  • Disable automatic comment, CI, and merge conflict monitoring

@staging-devin-ai-integration
staging-devin-ai-integration Bot force-pushed the devin/1791249287-taffy-grid-size-estimate-named-lines branch 12 times, most recently from a88fe13 to 9272b18 Compare October 8, 2026 13:51
@staging-devin-ai-integration staging-devin-ai-integration Bot changed the title Bump Taffy: named lines in grid size estimate (Taffy #1259) Bump Taffy: resolve grid placements once, named lines in grid size estimate (Taffy #1259) Oct 8, 2026
@staging-devin-ai-integration
staging-devin-ai-integration Bot force-pushed the devin/1791249287-taffy-grid-size-estimate-named-lines branch from 9272b18 to 1f2ae47 Compare October 8, 2026 14:05
@staging-devin-ai-integration staging-devin-ai-integration Bot changed the title Bump Taffy: resolve grid placements once, named lines in grid size estimate (Taffy #1259) Bump Taffy: named lines resolved once, before the grid size estimate (Taffy #1259) Oct 8, 2026
@staging-devin-ai-integration
staging-devin-ai-integration Bot force-pushed the devin/1791249287-taffy-grid-size-estimate-named-lines branch 2 times, most recently from d96c63b to 675f2b4 Compare October 8, 2026 14:16
@staging-devin-ai-integration
staging-devin-ai-integration Bot force-pushed the devin/1791249287-taffy-grid-size-estimate-named-lines branch from 675f2b4 to d4ba610 Compare October 8, 2026 14:27
@staging-devin-ai-integration staging-devin-ai-integration Bot changed the title Bump Taffy: named lines resolved once, before the grid size estimate (Taffy #1259) Bump Taffy to main: named lines resolved once, before the grid size estimate (Taffy #1259) Oct 8, 2026
@nicoburns nicoburns changed the title Bump Taffy to main: named lines resolved once, before the grid size estimate (Taffy #1259) Bump Taffy (named lines resolved once, before the grid size estimate) (Taffy #1259) Oct 8, 2026
@nicoburns
nicoburns merged commit 10dac35 into main Oct 8, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant