Repository navigation
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791198000-taffy-stretch-fixes
branch
2 times, most recently
from
October 9, 2026 15:17
4037743 to
9cbf9a0
Compare
stretch sizing fixes (block-axis margin rule, flex items)height: stretch margin rule)
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791198000-taffy-stretch-fixes
branch
from
October 9, 2026 16:29
9cbf9a0 to
6ffe48d
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791198000-taffy-stretch-fixes
branch
from
October 9, 2026 16:42
6ffe48d to
a9131fd
Compare
height: stretch margin rule)This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-pins
taffy(Cargo.toml+Cargo.lock) to6a36efbe, the commit on Taffymainthat merged DioxusLabs/taffy#1242. No Blitz code changes.That PR is a block layout fix: for
height: stretchon an in-flow child of a block container, each vertical margin is treated as zero if it could collapse through the matching edge of the containing block (no border/padding on that side, and the containing block does not establish a new BFC). Otherwise it is subtracted as before.css-sizing/stretch/block-height-008gains 40 subtests and loses 40. It has 80 children in vertical-writing-mode containers, each checked twice (the second time withdirection: rtl):height: stretchwidth: stretchvertical-rl/vertical-lrsideways-rl/sideways-lrSo the
vertical-*half now passes fully and all losses are in thesideways-*half.sideways-*writing modes are not supported yet (waiting on Stylo support).cssom-view/scroll-back-to-initial-positionis listed as newly failing here but not on #1156 or #1157, which include the same Taffy change.The remaining
block-height-011failures have the stretched block inside an inline<span>.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/3a06d93089f2434ba3519a7813dea1e8
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/3a06d93089f2434ba3519a7813dea1e8?variant=devin-insiders
Requested by: @nicoburns