Skip to content

Bump Taffy to 6a36efbe (Taffy #1242 merged) - #1046

Open
nicoburns wants to merge 1 commit into
mainfrom
devin/1791198000-taffy-stretch-fixes
Open

nicoburns wants to merge 1 commit into
mainfrom
devin/1791198000-taffy-stretch-fixes

Conversation

@nicoburns

@nicoburns nicoburns commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Summary

Re-pins taffy (Cargo.toml + Cargo.lock) to 6a36efbe, the commit on Taffy main that merged DioxusLabs/taffy#1242. No Blitz code changes.

That PR is a block layout fix: for height: stretch on an in-flow child of a block container, each vertical margin is treated as zero if it could collapse through the matching edge of the containing block (no border/padding on that side, and the containing block does not establish a new BFC). Otherwise it is subtracted as before.

css-sizing/stretch/block-height-008 gains 40 subtests and loses 40. It has 80 children in vertical-writing-mode containers, each checked twice (the second time with direction: rtl):

Container Child with height: stretch Child with width: stretch
vertical-rl / vertical-lr pass before and after (40) gained (40)
sideways-rl / sideways-lr lost (40) fail before and after (40)

So the vertical-* half now passes fully and all losses are in the sideways-* half. sideways-* writing modes are not supported yet (waiting on Stylo support).

cssom-view/scroll-back-to-initial-position is listed as newly failing here but not on #1156 or #1157, which include the same Taffy change.

The remaining block-height-011 failures have the stretched block inside an inline <span>.

Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/3a06d93089f2434ba3519a7813dea1e8
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/3a06d93089f2434ba3519a7813dea1e8?variant=devin-insiders
Requested by: @nicoburns

@staging-devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access that start with 'Devin'.

  • Disable automatic comment, CI, and merge conflict monitoring

@staging-devin-ai-integration
staging-devin-ai-integration Bot force-pushed the devin/1791198000-taffy-stretch-fixes branch 2 times, most recently from 4037743 to 9cbf9a0 Compare October 9, 2026 15:17
@staging-devin-ai-integration staging-devin-ai-integration Bot changed the title Bump Taffy to stretch sizing fixes (block-axis margin rule, flex items) Bump Taffy to 141f5e67 (Taffy #1242: block height: stretch margin rule) Oct 9, 2026
@staging-devin-ai-integration
staging-devin-ai-integration Bot force-pushed the devin/1791198000-taffy-stretch-fixes branch from 9cbf9a0 to 6ffe48d Compare October 9, 2026 16:29
@staging-devin-ai-integration
staging-devin-ai-integration Bot force-pushed the devin/1791198000-taffy-stretch-fixes branch from 6ffe48d to a9131fd Compare October 9, 2026 16:42
@staging-devin-ai-integration staging-devin-ai-integration Bot changed the title Bump Taffy to 141f5e67 (Taffy #1242: block height: stretch margin rule) Bump Taffy to 6a36efbe (Taffy #1242 merged) Oct 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant