Repository navigation
Add /wpt/runs page with the latest completed WPT run per browser - #33
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
…d show versions under browser names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
/wpt/runspage, similar to https://wpt.fyi/runs. It shows the latest wpt.fyi master run for each browser on the WPT comparison page, newest first by when it was added to wpt.fyi (created_at). A "Latest runs" link sits before "Focus areas" on/wpt.wpt_compare::PRODUCTSminusHIDDEN_PRODUCTS(Chrome Canary, Firefox Nightly, Safari TP, Ladybird, Servo), so the two pages can't drift apart.api/runs?label=master&max-count=5&product=…&product=…request, wheremax-countapplies to each product.alignedisn't set. The latest run is picked bycreated_atrather thantime_start, because a run that started earlier can finish later.created_at − time_end).mainrefreshesWPT_RUNS_CACHEon startup and then every hour, whether or not anyone visits.get_or_refresh(FRESH_FOR, Duration::MAX). Visitors never wait on a refresh.load_wpt_runsonly ever runs one refresh at a time, using a module-levelREFRESH_LOCK.refreshingis true:is_refreshing()checks whetherREFRESH_LOCKis held. The stale check covers the moment just afterget_or_refreshstarts a background refresh, before that refresh has taken the lock.In-progress runs, which need
GITHUB_TOKEN, are split out into #34, which is stacked on top of this PR.Testing
cargo clippy --all-targets: no new warnings. The only warning is the existing one insrc/downloads.rs./wpt/runs: 5 rows from live wpt.fyi data. A cold load took about 0.46s. After a restart, the first request was served from cache in about 1ms ("Updated just now") because of the startup refresh.FRESH_FORset to 3s. Loads of stale data showed "Refreshing data…", and it disappeared once the refresh finished.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/94bf6cad086a43818116ad129df06999
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/94bf6cad086a43818116ad129df06999?variant=devin-insiders
Requested by: @nicoburns