Skip to content

PREWAVE-BE-020 — Normalize Notification Preference Storage and Quiet-Hours Semantics #616

Closed

Description

@dDevAhmed

Problem context

Draft PR #608 proves deterministic installation under the pinned Node runtime, but hosted Gate B still fails at source compilation. This issue isolates one concrete failure family from the 77-error baseline.

Technical scope

  • Reconcile stale settings, enabledChannels, disabledCategories, and split quiet-hours fields with the canonical NotificationPreference entity.
  • Define migration/default behavior for existing rows.
  • Validate timezone and category/channel precedence.

Security and architecture constraints

  • Contracts and finalized canonical events remain authoritative for protocol state.
  • Do not conceal errors with broad casts, disabled strictness, skipped tests, or duplicate compatibility models.
  • Treat wallet, request, notification, support, and chain-derived inputs as untrusted.
  • Preserve fail-closed behavior for missing configuration and interface mismatches.

Required tests

  • Migration tests from each legacy shape.
  • Quiet-hours tests across DST, invalid timezone, overnight ranges, and boundaries.
  • Category/channel opt-out precedence tests.

Acceptance criteria

  • One documented preference schema remains.
  • Existing records migrate deterministically.
  • Quiet hours use an explicit timezone and boundary rule.
  • Mandatory security notices cannot be disabled unintentionally.

Dependencies

Non-goals

  • Bundling unrelated compile repairs.
  • Weakening TypeScript, lint, security, or container gates.
  • Mainnet deployment.
  • Applying Stellar Wave before maintainer activation.

Complexity and points

  • Medium — 150 points

Candidate only; activation remains maintainer-controlled.

Activity

  1. Ikechukwu-Patrick commented on Oct 15, 2026

    @Ikechukwu-Patrick
    Contributor

    @Ikechukwu-Patrick has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello maintainer, please i would love to work on this issue.
    I have reviewed it, it's something i can resolve.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ikechukwu-Patrick to this issue.

  2. kodinaka30-ship-it commented on Oct 15, 2026

    @kodinaka30-ship-it

    @kodinaka30-ship-it has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello maintainer please kindly review my application and assign this issues to me and I will deliver as soon as possible

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @kodinaka30-ship-it to this issue.

  3. drips-wave commented on Oct 16, 2026

    @drips-wave

    Congratulations, @Ikechukwu-Patrick! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @Ikechukwu-Patrick: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  4. added a commit that references this issue on Oct 19, 2026
  5. drips-wave commented on Oct 19, 2026

    @drips-wave

    This issue has been completed by @Ikechukwu-Patrick as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @Ikechukwu-Patrick: You earned 150 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions