Skip to content

fix(auth): prevent anonymous identity hijacking on duplicate username #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AryanYadav215 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(auth): prevent anonymous identity hijacking on duplicate username #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions packages/server/src/routes/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { FastifyInstance } from "fastify";
import { db } from "../db/index";
import { users } from "@intellicircle/shared";
import {
users,
anonymousAuthSchema,
upgradeAuthSchema,
loginAuthSchema,
Expand All @@ -25,20 +25,19 @@ export async function authRoutes(app: FastifyInstance) {
// Check if username already exists
const existingUsers = await db.select().from(users).where(eq(users.username, username)).limit(1);

let user;
let user: any; // Fix: Explicitly declare type to prevent TS implicit 'any' error

if (existingUsers.length > 0) {
user = existingUsers[0];
// If the user has an email, they are no longer anonymous. They must use standard login.
if (user.email) {
// Audit Log
await db.insert(authAuditLogs).values({
ipAddress: request.ip,
eventType: "signup_failed",
usernameOrEmailAttempted: username,
userAgent: request.headers['user-agent'] || null
});
return reply.status(403).send(createErrorResponse("Username is already claimed by a registered account. Please login.", "ACCOUNT_CLAIMED"));
}
// Audit Log for attempted collision/takeover
await db.insert(authAuditLogs).values({
ipAddress: request.ip,
eventType: "signup_failed",
usernameOrEmailAttempted: username,
userAgent: request.headers['user-agent'] || null
});

// Return 409 Conflict: Prevents takeover of anonymous OR registered accounts
return reply.status(409).send(createErrorResponse("Username is already taken.", "CONFLICT"));
} else {
// Create new anonymous user
const [newUser] = await db.insert(users).values({
Expand Down Expand Up @@ -182,8 +181,7 @@ export async function authRoutes(app: FastifyInstance) {
await blacklistToken(decoded.jti, 7 * 24 * 60 * 60 * 1000);

// Issue New Tokens
// Note: Utilizing `crypto.randomUUID()` for unique `jti` to ensure unique keys in Redis
const crypto = require('crypto');
// Fix: Removed 'const crypto = require("crypto");' redeclaration error here
const newJti = crypto.randomUUID();

const accessToken = app.jwt.sign({ id: user.id, username: user.username, role: user.role }, { expiresIn: "15m" });
Expand Down Expand Up @@ -222,4 +220,4 @@ export async function authRoutes(app: FastifyInstance) {

return reply.status(200).send(createSuccessResponse({ message: "Logged out" }));
});
}
}