fix(client): Resolve layout shift issue on the Profile page during data fetching - #217
Open
Daksh7785 wants to merge 2 commits into
Open
Conversation
|
Someone is attempting to deploy a commit to the Dharm3112's projects Team on Vercel. A member of the Team first needs to authorize it. |
👷 Deploy request for intellicircle pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replaces the
return nullfallback inpackages/client/src/app/(app)/profile/page.tsxwith a Skeleton loader.Why is this necessary?
As per Issue #91, the profile page previously returned
nullwhile waiting for the component to mount and the user state to hydrate. This caused a Cumulative Layout Shift (CLS) when the page suddenly rendered. The skeleton loader mimics the profile header and tab structure to provide a smooth visual transition.How was this verified?
npm run checkcompilation passes in client.Thank you for reviewing!