Repository navigation
fix: make portfolio grid keyboard accessible (#988) - #1039
Closed
danieloche635-bit wants to merge 1 commit into
Closed
danieloche635-bit wants to merge 1 commit into
danieloche635-bit wants to merge 1 commit into
Conversation
|
@danieloche635-bit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
The active cell was tracked only in a ref, so tabIndex never re-rendered and focus always returned to the first item after tabbing away. Group cells into real ARIA rows instead of one row per item, remove the duplicate legacy grid in ProfilePortfolioTab, and make ArtistCard a valid standalone button. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
danieloche635-bit
force-pushed
the
fix/988-portfolio-grid-keyboard-a11y
branch
from
October 19, 2026 11:32
8341e78 to
2044648
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #988.
Adds keyboard and screen-reader support to the portfolio grid, which was previously mouse-only.
Changes
app/components/PortfolioGrid.tsx— new accessible grid:role="grid"container witharia-label,aria-rowcountandaria-colcountrole="row"/role="gridcell"structure witharia-roledescription="portfolio item"aria-labelfor every item (title + description)tabIndex, with visiblefocus-visibleringHome/Endjump to first/last;Enter/Spaceselectapp/hooks/useFocusManagement.ts— reusable roving-tabindex hook for composite widgets; wraps navigation at edgestest/PortfolioGrid.test.tsx— 6 tests covering roles/ARIA, tab order, arrow navigation, wrapping, Home/End, activation, and empty statevitest.config.ts+test/setup.ts— project test runner configuration (jsdom + jest-dom), since the repository had no Vitest configAcceptance criteria
tabIndex=0)columnsrole="grid"androle="gridcell"are correctly appliedPortfolioGridis the only grid-like component in this repository; theArtistCard/WorkGalleryfiles referenced in the issue do not exist hereTesting
Screenshots
Keyboard focus ring and arrow-key movement can be verified by tabbing into the grid and using the arrow keys.