Skip to content

fix: nav focus-visible, wallet nonce replay, error server logs, theme… - #1027

Merged
ayshadogo merged 2 commits into
Dfunder:mainfrom
fadee26:fix/a11y-auth-errors-theme
Oct 18, 2026
Merged

ayshadogo merged 2 commits into
Dfunder:mainfrom
fadee26:fix/a11y-auth-errors-theme

Conversation

@fadee26

@fadee26 fadee26 commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #939, #934, #936, #938.

#939 – Navigation focus indicators

  • NAV_LINK_CLASSES / navFocus.ts: focus-visible:ring-2 ring-primary (+ offset)
  • Applied to header, mobile menu, logo, footer links in App.tsx
  • Reusable PrimaryNav, MobileNav, SecondaryNav
  • Test: navFocus.test.ts

#934 – Replay protection

  • Removed fallbackNonce / lumora-auth-nonce-… path in useWalletAuth
  • Challenge must come from authApi.requestWalletNonce
  • Doc: docs/WALLET_AUTH_REPLAY.md
  • Test: useWalletAuth.replay.test.ts

#936 – Error boundary → server

  • New lib/error-tracking.ts → POST /api/monitoring/errors
  • reportError also sends message, stack, componentStack, timestamp
  • UI stays friendly (no internal details)
  • Test: error-tracking.test.ts

#938 – Theme persistence

  • Already implemented via persistTheme / ThemeProvider + localStorage
  • Test: theme-persistence.test.ts (round-trip)

closes #938
closes #936
closes #934
closes #939

@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@fadee26 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@ayshadogo ayshadogo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GBEW

@ayshadogo
ayshadogo merged commit 886edd0 into Dfunder:main Oct 18, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants